Clean up media::DecryptingDemuxerStream.

Clean up media::DecryptingDemuxerStream.

Removes force-posting and DoXXX() methods since they're unnecessary.

Also removes stream_type_ member variable since it can be easily retrieved from demuxer_stream_->type().

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194721

[ddorwin, 2013-04-17 21:45:47]

Just a few questions. I'll defer to xhwang since he wrote this.

https://codereview.chromium.org/14232017/diff/1003/media/filters/decrypting_d...
File media/filters/decrypting_demuxer_stream.cc (right):

https://codereview.chromium.org/14232017/diff/1003/media/filters/decrypting_d...
media/filters/decrypting_demuxer_stream.cc:108:
CHECK_EQ(demuxer_stream_->type(), AUDIO);
Do we need to protect against demuxer_stream_ being NULL in all these cases or
is that programming error?

https://codereview.chromium.org/14232017/diff/1003/media/filters/decrypting_d...
media/filters/decrypting_demuxer_stream.cc:206: DVLOG(3) << "DeliverBuffer() -
status: " << status;
Synchronous calls from Reset() are no longer a concern? Just confirming.

[xhwang, 2013-04-17 22:14:47]

lgtm 

Thanks for the cleanup.

https://codereview.chromium.org/14232017/diff/1003/media/filters/decrypting_d...
File media/filters/decrypting_demuxer_stream.cc (right):

https://codereview.chromium.org/14232017/diff/1003/media/filters/decrypting_d...
media/filters/decrypting_demuxer_stream.cc:108:
CHECK_EQ(demuxer_stream_->type(), AUDIO);
On 2013/04/17 21:45:47, ddorwin wrote:
> Do we need to protect against demuxer_stream_ being NULL in all these cases or
> is that programming error?

I think audio_decoder_config should only be called after the DemuxerStream is
successfully initialized. So we should be fine here.

https://codereview.chromium.org/14232017/diff/1003/media/filters/decrypting_d...
media/filters/decrypting_demuxer_stream.cc:200:
BIND_TO_LOOP(&DecryptingDemuxerStream::DeliverBuffer));
Now I feel bad about AesDecryptor firing callbacks synchronouly...

https://codereview.chromium.org/14232017/diff/1003/media/filters/decrypting_d...
media/filters/decrypting_demuxer_stream.cc:206: DVLOG(3) << "DeliverBuffer() -
status: " << status;
On 2013/04/17 21:45:47, ddorwin wrote:
> Synchronous calls from Reset() are no longer a concern? Just confirming.

The BIND_TO_LOOP force posts the DecryptCB so we should be good here.

[scherkus (not reviewing), 2013-04-17 23:44:50]

Committed patchset #1 manually as r194721 (presubmit successful).