Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/spdy/spdy_test_util_spdy3.cc

Issue 14232014: Correctly handle SPDY GOAWAY frames. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/spdy/spdy_test_util_spdy3.h ('K') | « net/spdy/spdy_test_util_spdy3.h ('k') | net/spdy/spdy_write_queue.h » ('j') | net/spdy/spdy_write_queue.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_test_util_spdy3.cc
diff --git a/net/spdy/spdy_test_util_spdy3.cc b/net/spdy/spdy_test_util_spdy3.cc
index 0005366b67c999e216d4316cc50f551bf24d5405..56e823cabeee4b62e065e0b03910fb180d6f9c4e 100644
--- a/net/spdy/spdy_test_util_spdy3.cc
+++ b/net/spdy/spdy_test_util_spdy3.cc
@@ -200,8 +200,14 @@ SpdyFrame* ConstructSpdyPing(uint32 ping_id) {
// Construct a SPDY GOAWAY frame.
// Returns the constructed frame. The caller takes ownership of the frame.
SpdyFrame* ConstructSpdyGoAway() {
+ return ConstructSpdyGoAway(0);
+}
+
+// Construct a SPDY GOAWAY frame.
akalin 2013/04/17 21:14:20 here too
Ryan Hamilton 2013/04/18 00:30:40 ditto :>
+// Returns the constructed frame. The caller takes ownership of the frame.
+SpdyFrame* ConstructSpdyGoAway(SpdyStreamId last_good_stream_id) {
BufferedSpdyFramer framer(3, false);
- return framer.CreateGoAway(0, GOAWAY_OK);
+ return framer.CreateGoAway(last_good_stream_id, GOAWAY_OK);
}
// Construct a SPDY WINDOW_UPDATE frame.
« net/spdy/spdy_test_util_spdy3.h ('K') | « net/spdy/spdy_test_util_spdy3.h ('k') | net/spdy/spdy_write_queue.h » ('j') | net/spdy/spdy_write_queue.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698