Correctly handle SPDY GOAWAY frames.

net/spdy/spdy_write_queue_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_write_queue.h"
 
 #include <cstddef>
 #include <cstring>
 #include <string>
 
@@ skipping 160 matching lines @@
     EXPECT_EQ(i, ProducerToInt(frame_producer.Pass()));
     EXPECT_EQ(stream1, stream);
   }
 
   SpdyFrameType frame_type = DATA;
   scoped_ptr<SpdyBufferProducer> frame_producer;
   scoped_refptr<SpdyStream> stream;
   EXPECT_FALSE(write_queue.Dequeue(&frame_type, &frame_producer, &stream));
 }
 
+// Enqueue a bunch of writes and then call
+// RemovePendingWritesForStreamsAfter(). No dequeued write should be for
+// those streams without a stream id, or with a stream_id after that
+// argument.
+TEST_F(SpdyWriteQueueTest, RemovePendingWritesForStreamsAfter) {
+  SpdyWriteQueue write_queue;
+
+  scoped_refptr<SpdyStream> stream1(MakeTestStream(DEFAULT_PRIORITY));
+  stream1->set_stream_id(1);
+  scoped_refptr<SpdyStream> stream2(MakeTestStream(DEFAULT_PRIORITY));
+  stream2->set_stream_id(3);
+  scoped_refptr<SpdyStream> stream3(MakeTestStream(DEFAULT_PRIORITY));
+  stream3->set_stream_id(5);
+  // No stream id assigned.
+  scoped_refptr<SpdyStream> stream4(MakeTestStream(DEFAULT_PRIORITY));
+  scoped_refptr<SpdyStream> streams[] = {
+    stream1, stream2, stream3, stream4
+  };
+
+  for (int i = 0; i < 100; ++i) {
+    scoped_refptr<SpdyStream> stream = streams[i % arraysize(streams)];
+    write_queue.Enqueue(DEFAULT_PRIORITY, SYN_STREAM, IntToProducer(i), stream);
+  }
+
+  write_queue.RemovePendingWritesForStreamsAfter(stream1->stream_id());
+
+  for (int i = 0; i < 100; i += arraysize(streams)) {
+    SpdyFrameType frame_type = DATA;
+    scoped_ptr<SpdyBufferProducer> frame_producer;
+    scoped_refptr<SpdyStream> stream;
+    ASSERT_TRUE(write_queue.Dequeue(&frame_type, &frame_producer, &stream))
+        << "Unable to Dequeue i: "<< i;

[akalin, 2013/04/18 19:58:19]

space before second <<

[Ryan Hamilton, 2013/04/18 21:33:46]

Done.

+    EXPECT_EQ(SYN_STREAM, frame_type);
+    EXPECT_EQ(i, ProducerToInt(frame_producer.Pass()));
+    EXPECT_EQ(stream1, stream);
+  }
+
+  SpdyFrameType frame_type = DATA;
+  scoped_ptr<SpdyBufferProducer> frame_producer;
+  scoped_refptr<SpdyStream> stream;
+  EXPECT_FALSE(write_queue.Dequeue(&frame_type, &frame_producer, &stream));
+}
+
 // Enqueue a bunch of writes and then call Clear(). The write queue
 // should clean up the memory properly, and Dequeue() should return
 // false.
 TEST_F(SpdyWriteQueueTest, Clear) {
   SpdyWriteQueue write_queue;
 
   for (int i = 0; i < 100; ++i) {
     write_queue.Enqueue(DEFAULT_PRIORITY, SYN_STREAM, IntToProducer(i), NULL);
   }
 
   write_queue.Clear();
 
   SpdyFrameType frame_type = DATA;
   scoped_ptr<SpdyBufferProducer> frame_producer;
   scoped_refptr<SpdyStream> stream;
   EXPECT_FALSE(write_queue.Dequeue(&frame_type, &frame_producer, &stream));
 }
 
 }  // namespace
 
 }  // namespace net