Correctly handle SPDY GOAWAY frames.

net/spdy/spdy_write_queue.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_write_queue.h"
 
 #include <cstddef>
 
 #include "base/logging.h"
 #include "net/spdy/spdy_buffer.h"
@@ skipping 71 matching lines @@
     if (it->stream == stream) {
       delete it->frame_producer;
     } else {
       *out_it = *it;
       ++out_it;
     }
   }
   queue->erase(out_it, queue->end());
 }
 
+void SpdyWriteQueue::RemovePendingWritesForStreamsAfter(
+    SpdyStreamId last_good_stream_id) {
+  for (int i = 0; i < NUM_PRIORITIES; ++i) {
+    // Do the actual deletion and removal, preserving FIFO-ness.
+    std::deque<PendingWrite>* queue = &queue_[i];
+    std::deque<PendingWrite>::iterator out_it = queue->begin();
+    for (std::deque<PendingWrite>::const_iterator it = queue->begin();
+         it != queue->end(); ++it) {
+      if (it->stream && (it->stream->stream_id() > last_good_stream_id ||
+                         it->stream->stream_id() == 0)) {

[akalin, 2013/04/18 19:58:19]

ah, interesting. can you add to the header comment that we also delete writes
for streams with no ids?

[Ryan Hamilton, 2013/04/18 21:33:46]

Done.

+        delete it->frame_producer;
+      } else {
+        *out_it = *it;
+        ++out_it;
+      }
+    }
+    queue->erase(out_it, queue->end());
+  }
+}
+
 void SpdyWriteQueue::Clear() {
   for (int i = 0; i < NUM_PRIORITIES; ++i) {
     for (std::deque<PendingWrite>::iterator it = queue_[i].begin();
          it != queue_[i].end(); ++it) {
       delete it->frame_producer;
     }
     queue_[i].clear();
   }
 }
 
 }  // namespace net