Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 14232008: Fix building cctests with component=shared_library snapshot=off (Closed)

Created:
7 years, 8 months ago by Jakob Kummerow
Modified:
7 years, 8 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Fix building cctests with component=shared_library snapshot=off BUG=v8:2634 Committed: http://code.google.com/p/v8/source/detail?r=14319

Patch Set 1 #

Patch Set 2 : line break #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M test/cctest/cctest.gyp View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAQL.
7 years, 8 months ago (2013-04-17 17:01:21 UTC) #1
Yang
On 2013/04/17 17:01:21, Jakob wrote: > PTAQL. LGTM.
7 years, 8 months ago (2013-04-17 17:02:10 UTC) #2
Jakob Kummerow
7 years, 8 months ago (2013-04-17 17:02:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r14319 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698