Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: chrome/browser/extensions/api/management/management_apitest.cc

Issue 14232006: Re-enable various ExtensionManagementApiTest tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/management/management_apitest.cc
diff --git a/chrome/browser/extensions/api/management/management_apitest.cc b/chrome/browser/extensions/api/management/management_apitest.cc
index 9c30685f3679066fdaaa08cd8d83b6d512e243b4..f43c9d1e1ab32810417c0862087b5607b8563b05 100644
--- a/chrome/browser/extensions/api/management/management_apitest.cc
+++ b/chrome/browser/extensions/api/management/management_apitest.cc
@@ -108,14 +108,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, Basics) {
ASSERT_TRUE(RunExtensionSubtest("management/test", "basics.html"));
}
-// Disabled: http://crbug.com/174411
-#if defined(OS_WIN)
-#define MAYBE_Uninstall DISABLED_Uninstall
-#else
-#define MAYBE_Uninstall Uninstall
-#endif
-
-IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, MAYBE_Uninstall) {
+IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, Uninstall) {
LoadExtensions();
ASSERT_TRUE(RunExtensionSubtest("management/test", "uninstall.html"));
}
@@ -158,8 +151,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, ManagementPolicyProhibited) {
"prohibited.html"));
}
-// Disabled. See http://crbug.com/176023
-IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, DISABLED_LaunchPanelApp) {
+IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, LaunchPanelApp) {
ExtensionService* service = extensions::ExtensionSystem::Get(
browser()->profile())->extension_service();
@@ -218,13 +210,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, DISABLED_LaunchPanelApp) {
ASSERT_TRUE(app_browser->is_app());
}
-// Disabled: http://crbug.com/230165
-#if defined(OS_WIN)
-#define MAYBE_LaunchTabApp DISABLED_LaunchTabApp
-#else
-#define MAYBE_LaunchTabApp LaunchTabApp
-#endif
-IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, MAYBE_LaunchTabApp) {
+IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, LaunchTabApp) {
ExtensionService* service = extensions::ExtensionSystem::Get(
browser()->profile())->extension_service();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698