Implemented the BufferedRawMachineAssemblerTester.

Implement the BufferedRawMachineAssemblerTester.

This utility makes it possible to test TF graphs that accept parameters of any machine type (even int64 and float64), which are previously problematic due to the complexity of C calling conventions.

R=titzer@chromium.org

Committed: https://crrev.com/44b520f57ffc1ec790de271ee92d514f40856a14
Cr-Commit-Position: refs/heads/master@{#31698}

[titzer, 2015-10-30 19:48:52]

looks good with some small nits

https://codereview.chromium.org/1423133005/diff/100001/test/cctest/compiler/c...
File test/cctest/compiler/codegen-tester.cc (right):

https://codereview.chromium.org/1423133005/diff/100001/test/cctest/compiler/c...
test/cctest/compiler/codegen-tester.cc:596: CHECK_EQ(0x600000000,
m.Call(0x100000000, 0x200000000, 0x300000000));
Probably want to check some real 64-bit numbers here. There should be some
MACRO-loops in value-helper.h

https://codereview.chromium.org/1423133005/diff/100001/test/cctest/compiler/c...
File test/cctest/compiler/codegen-tester.h (right):

https://codereview.chromium.org/1423133005/diff/100001/test/cctest/compiler/c...
test/cctest/compiler/codegen-tester.h:284: 
Extra newline

[ahaas, 2015-10-30 21:13:09]

https://codereview.chromium.org/1423133005/diff/100001/test/cctest/compiler/c...
File test/cctest/compiler/codegen-tester.cc (right):

https://codereview.chromium.org/1423133005/diff/100001/test/cctest/compiler/c...
test/cctest/compiler/codegen-tester.cc:596: CHECK_EQ(0x600000000,
m.Call(0x100000000, 0x200000000, 0x300000000));
On 2015/10/30 19:48:52, titzer wrote:
> Probably want to check some real 64-bit numbers here. There should be some
> MACRO-loops in value-helper.h

Done.

https://codereview.chromium.org/1423133005/diff/100001/test/cctest/compiler/c...
File test/cctest/compiler/codegen-tester.h (right):

https://codereview.chromium.org/1423133005/diff/100001/test/cctest/compiler/c...
test/cctest/compiler/codegen-tester.h:284: 
On 2015/10/30 19:48:52, titzer wrote:
> Extra newline

Done.

[titzer, 2015-10-30 21:17:16]

Please add a one or two sentence explanation to the CL description, for
posterity.

LGTM

[titzer, 2015-10-30 21:18:23]

Description was changed from

==========
Implemented the BufferedRawMachineAssemblerTester.

R=titzer@chromium.org
==========

to

==========
Implement the BufferedRawMachineAssemblerTester.

This utility makes it possible to test TF graphs that accept parameters of any
machine type (even int64 and float64), which are previously problematic due to
the complexity of C calling conventions.

R=titzer@chromium.org
==========

[titzer, 2015-10-30 21:18:52]

On 2015/10/30 21:17:16, titzer wrote:
> Please add a one or two sentence explanation to the CL description, for
> posterity.

Don't worry, I already went ahead and did that.

[ahaas, 2015-10-30 21:27:10]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2015-10-30 21:27:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1423133005/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1423133005/120001

[commit-bot: I haz the power, 2015-10-30 21:32:43]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-10-30 21:33:00]

Patchset 7 (id:??) landed as
https://crrev.com/44b520f57ffc1ec790de271ee92d514f40856a14
Cr-Commit-Position: refs/heads/master@{#31698}