Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1423133003: Routes calls to WM through WS (Closed)

Created:
5 years, 1 month ago by sky
Modified:
5 years, 1 month ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, tfarina, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Routes calls to WM through WS By doing this we ensure the WM sees changes to the underlying windows before any calls to the WM are received. BUG=none TEST=none R=ben@chromium.org Committed: https://crrev.com/40766911c1bccdb7ee615616fc9377abe121b308 Cr-Commit-Position: refs/heads/master@{#356429}

Patch Set 1 #

Patch Set 2 : unnecessary space #

Patch Set 3 : merge 2 trunk #

Total comments: 2

Patch Set 4 : no braces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -121 lines) Patch
M components/mus/example/wm/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/example/wm/window_manager_application.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M components/mus/example/wm/window_manager_application.cc View 1 2 3 3 chunks +8 lines, -3 lines 0 comments Download
M components/mus/example/wm/window_manager_impl.h View 1 2 3 chunks +2 lines, -9 lines 0 comments Download
M components/mus/example/wm/window_manager_impl.cc View 1 2 6 chunks +2 lines, -28 lines 0 comments Download
M components/mus/mus_app.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/mus_app.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M components/mus/public/cpp/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M components/mus/public/cpp/lib/window.cc View 1 2 2 chunks +20 lines, -0 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.h View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.cc View 1 2 3 chunks +27 lines, -0 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_host_factory.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M components/mus/public/cpp/tests/window_server_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/window.h View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M components/mus/public/cpp/window_tree_host_factory.h View 2 chunks +5 lines, -2 lines 0 comments Download
M components/mus/public/interfaces/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/public/interfaces/window_manager.mojom View 1 2 1 chunk +1 line, -28 lines 0 comments Download
A components/mus/public/interfaces/window_manager_constants.mojom View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M components/mus/public/interfaces/window_tree.mojom View 1 2 2 chunks +15 lines, -1 line 0 comments Download
M components/mus/public/interfaces/window_tree_host.mojom View 2 chunks +3 lines, -1 line 0 comments Download
M components/mus/ws/window_tree_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_tree_host_impl.h View 3 chunks +5 lines, -1 line 0 comments Download
M components/mus/ws/window_tree_host_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M components/mus/ws/window_tree_impl.h View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M components/mus/ws/window_tree_impl.cc View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
M components/mus/ws/window_tree_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/web_view/frame_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/web_view/test_runner/test_runner_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/ui/desktop_ui/browser_window.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mandoline/ui/phone_ui/phone_browser_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/native_widget_mus.h View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 1 2 4 chunks +5 lines, -22 lines 0 comments Download
M ui/views/mus/window_manager_connection.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
sky
I need to merge with your patch, but this is enough to give you a ...
5 years, 1 month ago (2015-10-27 19:26:16 UTC) #1
sky
Merged with your changes, ready to review.
5 years, 1 month ago (2015-10-27 20:51:10 UTC) #2
Ben Goodger (Google)
lgtm https://codereview.chromium.org/1423133003/diff/40001/components/mus/example/wm/window_manager_application.cc File components/mus/example/wm/window_manager_application.cc (right): https://codereview.chromium.org/1423133003/diff/40001/components/mus/example/wm/window_manager_application.cc#newcode54 components/mus/example/wm/window_manager_application.cc:54: for (auto request : requests_) { nit: no ...
5 years, 1 month ago (2015-10-27 22:25:05 UTC) #3
sky
https://codereview.chromium.org/1423133003/diff/40001/components/mus/example/wm/window_manager_application.cc File components/mus/example/wm/window_manager_application.cc (right): https://codereview.chromium.org/1423133003/diff/40001/components/mus/example/wm/window_manager_application.cc#newcode54 components/mus/example/wm/window_manager_application.cc:54: for (auto request : requests_) { On 2015/10/27 22:25:05, ...
5 years, 1 month ago (2015-10-27 22:30:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423133003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423133003/60001
5 years, 1 month ago (2015-10-27 22:33:35 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-10-27 23:27:32 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 23:28:18 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/40766911c1bccdb7ee615616fc9377abe121b308
Cr-Commit-Position: refs/heads/master@{#356429}

Powered by Google App Engine
This is Rietveld 408576698