Split <object> tests further to reduce timeout risk

third_party/WebKit/LayoutTests/svg/as-object/sizing/svg-in-object.js

 // global async_test, assert_equals
 //
 // This test generates a couple of scenarios (each a TestData) for
 // sizing SVG inside an inline <object> and has a simple JavaScript
 // sizing implementation that handles the generated scenarios. It
 // generates a DOM corresponding to the scenario and compares the laid
 // out size to the calculated size.
 //
 // The tests loops through different combinations of:
 //
@@ skipping 368 matching lines @@
     doCombinationTestRecursive(values, {});
 }
 
 var debugHint = function(id) { return "(append ?"+id+" to debug) " };
 var testSingleId;
 if (window.location.search) {
     testSingleId = window.location.search.substring(1);
     debugHint = function(id) { return ""; };
 }
 
-function testSVGInObjectWithPlaceholderHeightAttr(placeholderHeightAttr) {
-    // Separated over placeholderHeightAttr so that the test count is around ~200
-
+function testSVGInObjectWithPlaceholder(placeholderWidthAttr, placeholderHeightAttr) {
     doCombinationTest(
         [["containerWidthStyle", [null, "400px"]],
          ["containerHeightStyle", [null, "400px"]],
-         ["placeholderWidthAttr", [null, "100", "50%"]],
+         ["placeholderWidthAttr", [placeholderWidthAttr]],
          ["placeholderHeightAttr", [placeholderHeightAttr]],
          ["svgViewBoxAttr", [ null, "0 0 100 200" ]],
          ["svgWidthAttr", [ null, "200", "25%" ]],
          ["svgHeightAttr", [ null, "200", "25%" ]]],
         function(config, id) {
             if (!testSingleId || testSingleId == id) {
                 var testData = new TestData(config);
                 var t = async_test(testData.name);
 
                 var expectedRect =
                         testData.computeInlineReplacedSize();
                 var placeholder = setupPlaceholder(testData);
                 var container =
                         setupContainer(testData, placeholder);
 
                 var checkSize = function() {
                     var placeholderRect =
                             placeholder.getBoundingClientRect();
 
                     try {
-                        assert_equals(placeholderRect.width,
-                                      expectedRect.width,
-                                      debugHint(id) + "Wrong width");
-                        assert_equals(placeholderRect.height,
-                                      expectedRect.height,
-                                      debugHint(id) + "Wrong height");
+                        assert_approx_equals(placeholderRect.width,
+                                             expectedRect.width,
+                                             1,

[fs, 2015/10/29 09:52:46]

One full (CSS) pixel seems a bit high as an error bound, but I suppose it's not
_that_ high in a relative sense.

[davve, 2015/10/29 10:16:10]

Yes, I had roughly the same thought but it felt slightly silly writing a smaller
number. Does 0.5 feel more balanced to you?

[fs, 2015/10/29 10:19:41]

0.5 would be "within one pixel" (rather than "within two pixels"), so that seems
better.

[davve, 2015/10/29 10:30:33]

Done.

+                                             debugHint(id) + "Wrong width");
+                        assert_approx_equals(placeholderRect.height,
+                                             expectedRect.height,
+                                             1,
+                                             debugHint(id) + "Wrong height");
                     } finally {
                         testContainer.removeChild(container);
                         if (testSingleId)
                             document.body.removeChild(testContainer);
                     }
                     t.done();
                 };
 
                 t.step(function() {
                     placeholder.addEventListener('load', function() {
@@ skipping 20 matching lines @@
                 iframe.src = "data:text/html;charset=utf-8," + encodeURIComponent(demo);
                 document.body.appendChild(iframe);
 
                 document.body.insertAdjacentHTML(
                     'beforeEnd',
                     '<p><a href="data:application/octet-stream;charset=utf-8;base64,' +
                         btoa(demo) + '" download="svg-in-object-test-' + pad(id, 3) + '.html">Download</a></p>');
             }
         });
 }