Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1423063006: XFA: Sync samples/ build files with master. (Closed)

Created:
5 years, 1 month ago by Lei Zhang
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

XFA: Sync samples/ build files with master. This makes pdfium_test always link with the bundled freetype, which will fix many failing corpus tests. This merges snippets of 34bb6c58fe60206a08dc0a1f37b7cfe83e8c762c R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/461b634b8b45bf022412b364fac37f6ad3cafb69

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -16 lines) Patch
M samples/BUILD.gn View 4 chunks +13 lines, -4 lines 0 comments Download
M samples/samples.gyp View 3 chunks +14 lines, -11 lines 0 comments Download
M third_party/third_party.gyp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Lei Zhang
https://codereview.chromium.org/1423063006/diff/1/samples/BUILD.gn File samples/BUILD.gn (right): https://codereview.chromium.org/1423063006/diff/1/samples/BUILD.gn#newcode11 samples/BUILD.gn:11: ":pdfium_diff", Wrong order, but so is master. https://codereview.chromium.org/1423063006/diff/1/samples/samples.gyp File ...
5 years, 1 month ago (2015-11-06 05:11:29 UTC) #3
Tom Sepez
lgtm
5 years, 1 month ago (2015-11-06 17:26:45 UTC) #4
Lei Zhang
5 years, 1 month ago (2015-11-06 18:36:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
461b634b8b45bf022412b364fac37f6ad3cafb69 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698