OLD | NEW |
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file | 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file |
2 // for details. All rights reserved. Use of this source code is governed by a | 2 // for details. All rights reserved. Use of this source code is governed by a |
3 // BSD-style license that can be found in the LICENSE file. | 3 // BSD-style license that can be found in the LICENSE file. |
4 | 4 |
5 #include "vm/flow_graph_range_analysis.h" | 5 #include "vm/flow_graph_range_analysis.h" |
6 | 6 |
7 #include "vm/bit_vector.h" | 7 #include "vm/bit_vector.h" |
| 8 #include "vm/compiler.h" |
8 #include "vm/il_printer.h" | 9 #include "vm/il_printer.h" |
9 | 10 |
10 namespace dart { | 11 namespace dart { |
11 | 12 |
12 DEFINE_FLAG(bool, array_bounds_check_elimination, true, | 13 DEFINE_FLAG(bool, array_bounds_check_elimination, true, |
13 "Eliminate redundant bounds checks."); | 14 "Eliminate redundant bounds checks."); |
14 DEFINE_FLAG(bool, trace_range_analysis, false, "Trace range analysis progress"); | 15 DEFINE_FLAG(bool, trace_range_analysis, false, "Trace range analysis progress"); |
15 DEFINE_FLAG(bool, trace_integer_ir_selection, false, | 16 DEFINE_FLAG(bool, trace_integer_ir_selection, false, |
16 "Print integer IR selection optimization pass."); | 17 "Print integer IR selection optimization pass."); |
17 DECLARE_FLAG(bool, trace_constant_propagation); | 18 DECLARE_FLAG(bool, trace_constant_propagation); |
(...skipping 1503 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
1521 | 1522 |
1522 RangeAnalysis* range_analysis_; | 1523 RangeAnalysis* range_analysis_; |
1523 FlowGraph* flow_graph_; | 1524 FlowGraph* flow_graph_; |
1524 Scheduler scheduler_; | 1525 Scheduler scheduler_; |
1525 }; | 1526 }; |
1526 | 1527 |
1527 | 1528 |
1528 void RangeAnalysis::EliminateRedundantBoundsChecks() { | 1529 void RangeAnalysis::EliminateRedundantBoundsChecks() { |
1529 if (FLAG_array_bounds_check_elimination) { | 1530 if (FLAG_array_bounds_check_elimination) { |
1530 const Function& function = flow_graph_->function(); | 1531 const Function& function = flow_graph_->function(); |
| 1532 // Generalization only if we have not deoptimized on a generalized |
| 1533 // check earlier, or we're compiling precompiled code (no |
| 1534 // optimistic hoisting of checks possible) |
1531 const bool try_generalization = | 1535 const bool try_generalization = |
1532 function.allows_bounds_check_generalization(); | 1536 function.allows_bounds_check_generalization() && |
| 1537 !Compiler::always_optimize(); |
1533 | 1538 |
1534 BoundsCheckGeneralizer generalizer(this, flow_graph_); | 1539 BoundsCheckGeneralizer generalizer(this, flow_graph_); |
1535 | 1540 |
1536 for (intptr_t i = 0; i < bounds_checks_.length(); i++) { | 1541 for (intptr_t i = 0; i < bounds_checks_.length(); i++) { |
1537 CheckArrayBoundInstr* check = bounds_checks_[i]; | 1542 CheckArrayBoundInstr* check = bounds_checks_[i]; |
1538 RangeBoundary array_length = | 1543 RangeBoundary array_length = |
1539 RangeBoundary::FromDefinition(check->length()->definition()); | 1544 RangeBoundary::FromDefinition(check->length()->definition()); |
1540 if (check->IsRedundant(array_length)) { | 1545 if (check->IsRedundant(array_length)) { |
1541 check->RemoveFromGraph(); | 1546 check->RemoveFromGraph(); |
1542 } else if (try_generalization) { | 1547 } else if (try_generalization) { |
(...skipping 1610 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
3153 } | 3158 } |
3154 } while (CanonicalizeMaxBoundary(&max) || | 3159 } while (CanonicalizeMaxBoundary(&max) || |
3155 CanonicalizeMinBoundary(&canonical_length)); | 3160 CanonicalizeMinBoundary(&canonical_length)); |
3156 | 3161 |
3157 // Failed to prove that maximum is bounded with array length. | 3162 // Failed to prove that maximum is bounded with array length. |
3158 return false; | 3163 return false; |
3159 } | 3164 } |
3160 | 3165 |
3161 | 3166 |
3162 } // namespace dart | 3167 } // namespace dart |
OLD | NEW |