Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: mojo/runner/BUILD.gn

Issue 1423063004: Allow Chrome to bind an Application request from mojo_runner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@callback
Patch Set: . Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/runner/BUILD.gn
diff --git a/mojo/runner/BUILD.gn b/mojo/runner/BUILD.gn
index 6dd9642401a1c844eab46ae42627984e3551b4ed..cc0f1664814e633216bc4cc001c3b747835a6eaa 100644
--- a/mojo/runner/BUILD.gn
+++ b/mojo/runner/BUILD.gn
@@ -7,10 +7,6 @@ import("//mojo/public/mojo_application.gni")
import("//testing/test.gni")
import("//third_party/mojo/src/mojo/public/tools/bindings/mojom.gni")
-# We don't support building in the component build since mojo apps are
-# inherently components.
-assert(!is_component_build)
-
group("runner") {
testonly = true
@@ -166,10 +162,12 @@ source_set("lib") {
":switches",
]
- data_deps = [
- "//components/devtools_service",
- "//mojo/services/tracing",
- ]
+ if (!is_component_build) {
+ data_deps = [
+ "//components/devtools_service",
+ "//mojo/services/tracing",
+ ]
+ }
if (is_android) {
sources += [
« chrome/browser/mojo_runner_state.h ('K') | « mojo/application/public/cpp/lib/application_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698