Allow Chrome to bind an Application request from mojo_runner.

Allow Chrome to bind an Application request from mojo_runner.

When chrome.exe is run from mojo_runner, block on startup until the InterfaceRequest<Application> is bound, and a message loop is run until the runner's shell sends Initialize().

R=sky@chromium.org
http://crbug.com/548694

Committed: https://crrev.com/2b4a62d4282df3fe69696925a6b84fdca1df2d0f
Cr-Commit-Position: refs/heads/master@{#358145}

Committed: https://crrev.com/0cc0be91569cbc1942803b01a5c8001f58e48328
Cr-Commit-Position: refs/heads/master@{#358668}

[Ben Goodger (Google), 2015-11-04 22:18:22]

Description was changed from

==========
Allow Chrome to bind an Application request from mojo_runner.

When chrome.exe is run from mojo_runner, block on startup until the
InterfaceRequest<Application> is bound, and a message loop is run until the
runner's shell sends Initialize().

R=sky@chromium.org
http://crbug.com/548694
==========

to

==========
Allow Chrome to bind an Application request from mojo_runner.

When chrome.exe is run from mojo_runner, block on startup until the
InterfaceRequest<Application> is bound, and a message loop is run until the
runner's shell sends Initialize().

R=sky@chromium.org
http://crbug.com/548694
==========

[sky, 2015-11-05 00:29:34]

https://codereview.chromium.org/1423063004/diff/40001/chrome/browser/chrome_b...
File chrome/browser/chrome_browser_main.cc (right):

https://codereview.chromium.org/1423063004/diff/40001/chrome/browser/chrome_b...
chrome/browser/chrome_browser_main.cc:590: base::MessageLoop::current()->Run();
You sure you want to run a nested message loop here? The down side of doing a
message loop is you run the risk of pumping events you don't want to run at this
point. I wonder if it would be better to move this onto a dedicated thread and
wait on a mutex here.

Either way, I think it would be better to isolate all this code (this class and
the new code below) into a single class that is owned by ChromeBrowserMain. Less
ifdefs then.

https://codereview.chromium.org/1423063004/diff/40001/chrome/browser/mojo_run...
File chrome/browser/mojo_runner_util.h (right):

https://codereview.chromium.org/1423063004/diff/40001/chrome/browser/mojo_run...
chrome/browser/mojo_runner_util.h:8: namespace chrome {
nit: latest thinking on naming is no chrome namespace. So, don't use any
namespace here.

[Ben Goodger (Google), 2015-11-05 04:55:47]

So to do this I'd have to bind the Application request on the other thread,
since that's the interface Initialize() is sent to. I don't think I like
that idea as ApplicationImpl, ApplicationDelegate etc are not thread safe.

-Ben

On Wed, Nov 4, 2015 at 4:29 PM, <sky@chromium.org> wrote:

>
>
>
https://codereview.chromium.org/1423063004/diff/40001/chrome/browser/chrome_b...
> File chrome/browser/chrome_browser_main.cc (right):
>
>
>
https://codereview.chromium.org/1423063004/diff/40001/chrome/browser/chrome_b...
> chrome/browser/chrome_browser_main.cc:590:
> base::MessageLoop::current()->Run();
> You sure you want to run a nested message loop here? The down side of
> doing a message loop is you run the risk of pumping events you don't
> want to run at this point. I wonder if it would be better to move this
> onto a dedicated thread and wait on a mutex here.
>
> Either way, I think it would be better to isolate all this code (this
> class and the new code below) into a single class that is owned by
> ChromeBrowserMain. Less ifdefs then.
>
>
>
https://codereview.chromium.org/1423063004/diff/40001/chrome/browser/mojo_run...
> File chrome/browser/mojo_runner_util.h (right):
>
>
>
https://codereview.chromium.org/1423063004/diff/40001/chrome/browser/mojo_run...
> chrome/browser/mojo_runner_util.h:8: namespace chrome {
> nit: latest thinking on naming is no chrome namespace. So, don't use any
> namespace here.
>
> https://codereview.chromium.org/1423063004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sky, 2015-11-05 17:07:57]

Good point. As ApplicationImpl hides the binding you don't have a good
way to move it between threads. Another option is to expose
WaitForIncomingMethodCall() on ApplicationImpl. That would let you
block the main thread directly rather than running a nested message
loop.

On Wed, Nov 4, 2015 at 8:55 PM, Ben Goodger (Google) <ben@chromium.org> wrote:
> So to do this I'd have to bind the Application request on the other thread,
> since that's the interface Initialize() is sent to. I don't think I like
> that idea as ApplicationImpl, ApplicationDelegate etc are not thread safe.
>
> -Ben
>
> On Wed, Nov 4, 2015 at 4:29 PM, <sky@chromium.org> wrote:
>>
>>
>>
>>
https://codereview.chromium.org/1423063004/diff/40001/chrome/browser/chrome_b...
>> File chrome/browser/chrome_browser_main.cc (right):
>>
>>
>>
https://codereview.chromium.org/1423063004/diff/40001/chrome/browser/chrome_b...
>> chrome/browser/chrome_browser_main.cc:590:
>> base::MessageLoop::current()->Run();
>> You sure you want to run a nested message loop here? The down side of
>> doing a message loop is you run the risk of pumping events you don't
>> want to run at this point. I wonder if it would be better to move this
>> onto a dedicated thread and wait on a mutex here.
>>
>> Either way, I think it would be better to isolate all this code (this
>> class and the new code below) into a single class that is owned by
>> ChromeBrowserMain. Less ifdefs then.
>>
>>
>>
https://codereview.chromium.org/1423063004/diff/40001/chrome/browser/mojo_run...
>> File chrome/browser/mojo_runner_util.h (right):
>>
>>
>>
https://codereview.chromium.org/1423063004/diff/40001/chrome/browser/mojo_run...
>> chrome/browser/mojo_runner_util.h:8: namespace chrome {
>> nit: latest thinking on naming is no chrome namespace. So, don't use any
>> namespace here.
>>
>> https://codereview.chromium.org/1423063004/
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ben Goodger (Google), 2015-11-05 19:16:51]

PTAL

[sky, 2015-11-05 19:21:29]

LGTM

https://codereview.chromium.org/1423063004/diff/80001/chrome/browser/chrome_b...
File chrome/browser/chrome_browser_main.h (right):

https://codereview.chromium.org/1423063004/diff/80001/chrome/browser/chrome_b...
chrome/browser/chrome_browser_main.h:23: class ChromeApplicationDelegate;
remove this (it is only needed in mojo_runner_state)

https://codereview.chromium.org/1423063004/diff/80001/chrome/browser/mojo_run...
File chrome/browser/mojo_runner_state.h (right):

https://codereview.chromium.org/1423063004/diff/80001/chrome/browser/mojo_run...
chrome/browser/mojo_runner_state.h:20: // Creating an instance of this class
blocks the calling thread until a
nit: have constructor just setup state and Init() or Run() do the blocking.

https://codereview.chromium.org/1423063004/diff/80001/chrome/browser/mojo_run...
chrome/browser/mojo_runner_state.h:34: scoped_ptr<ChromeApplicationDelegate>
application_delegate_;
You need to forward declare ChromeApplicationDelegate.

[Ben Goodger (Google), 2015-11-05 19:27:23]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2015-11-05 19:27:23]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1423063004/#ps100001
(title: ".")

[commit-bot: I haz the power, 2015-11-05 19:28:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1423063004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1423063004/100001

[commit-bot: I haz the power, 2015-11-05 20:13:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-05 20:13:37]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ben Goodger (Google), 2015-11-05 21:33:42]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2015-11-05 21:34:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1423063004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1423063004/100001

[commit-bot: I haz the power, 2015-11-05 22:13:56]

Committed patchset #7 (id:100001)

[commit-bot: I haz the power, 2015-11-05 22:14:54]

Patchset 7 (id:??) landed as
https://crrev.com/2b4a62d4282df3fe69696925a6b84fdca1df2d0f
Cr-Commit-Position: refs/heads/master@{#358145}

[nasko, 2015-11-05 23:24:11]

A revert of this CL (patchset #7 id:100001) has been created in
https://codereview.chromium.org/1427393002/ by nasko@chromium.org.

The reason for reverting is: Reverting, as it broke the ChromeOS GN bots.
Reverting the other Mojo change (https://codereview.chromium.org/1406073004) did
not help, so reverting this one as well.

[2774/2777] LINK ./unit_tests
FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -pie
-Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro
-Wl,-z,defs -B../../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold
-Wl,--icf=all -pthread -m64 -Wl,-rpath=\$ORIGIN/ -Wl,-rpath-link=
-Wl,--disable-new-dtags -Wl,--export-dynamic -o ./chrome -Wl,--start-group
@./chrome.rsp ./libbase.so ./libbase_i18n.so ./libicui18n.so ./libicuuc.so
./libprefs.so ./libui_base.so ./libskia.so ./libplatform.so ./libevents_base.so
./libgfx.so ./libgeometry.so ./liburl.so ./libnet.so ./libprotobuf_lite.so
./libcrcrypto.so ./libboringssl.so ./libnative_theme.so
./libkeyed_service_core.so ./libsql.so ./libwebdata_common.so ./libsessions.so
./libprotocol.so ./libcontent.so ./libmojo_system_impl.so ./libgpu.so
./libsync.so ./libcloud_policy_proto_generated_compile.so
./libpolicy_component.so ./libproto.so ./libmojo_environment_impl.so ./libipc.so
./libcommon.so ./libgin.so ./libv8.so ./libppapi_shared.so ./libaccessibility.so
./libgfx_ipc.so ./libgl_wrapper.so ./libmessage_center.so ./libblink_common.so
./libblink_web.so ./libblink_platform.so ./libgles2_c_lib.so ./libmedia.so
./libdevice_event_log.so ./libdevice_core.so ./libchromeos.so ./libdbus.so
./liburl_matcher.so ./libbluetooth.so ./libkeyboard_with_content.so
./libprinting.so ./libkeyed_service_content.so ./libonc.so
./libshared_memory_support.so ./libgcm.so ./libstorage_common.so
./libui_base_ime.so ./libstorage_browser.so ./libchrome_apps.so ./libcc.so
./libppapi_host.so ./libaura.so ./libcompositor.so ./libevents.so ./libviews.so
./libash.so ./libkeyboard.so ./libx11_events_platform.so ./libdevices.so
./libgfx_x11.so ./libwebview.so ./libgesture_detection.so ./libsnapshot.so
./libbrowser_ui_views.so ./libnet_with_v8.so ./libsurface.so ./libweb_dialogs.so
./libppapi_proxy.so ./libwallpaper.so ./libash_with_content.so ./liblogin.so
./libcore.so ./libuser_manager.so ./libownership.so ./libproxy_config.so
./libapp_list.so ./libui_chromeos.so ./libdisplay.so ./libfile_manager.so
./libwm.so ./libcaptive_portal.so ./libdomain_reliability.so
./libchromium_sqlite3.so ./libstartup_tracing.so ./libuser_prefs.so
./libshell_dialogs.so ./libmidi.so ./libmojo_common_lib.so ./libmessage_pump.so
./libgles2_implementation.so ./libgles2_utils.so ./libtranslator.so
-Wl,--end-group  -ldl -lpangocairo-1.0 -lpango-1.0 -lcairo -lgobject-2.0
-lglib-2.0 -lX11 -lXcomposite -lXcursor -lXdamage -lXext -lXfixes -lXi -lXrender
-lXtst -ldbus-1 -lpthread -lrt -lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4
-lexpat -lXrandr -lm -lfontconfig -lfreetype 
../../third_party/mojo/src/mojo/edk/embedder/embedder.cc:132:error: undefined
reference to 'mojo::edk::internal::g_core'
../../third_party/mojo/src/mojo/edk/embedder/entrypoints.cc:33:error: undefined
reference to 'mojo::edk::internal::g_core'
../../third_party/mojo/src/mojo/edk/embedder/entrypoints.cc:39:error: undefined
reference to 'mojo::edk::internal::g_core'
../../third_party/mojo/src/mojo/edk/embedder/entrypoints.cc:48:error: undefined
reference to 'mojo::edk::internal::g_core'
../../third_party/mojo/src/mojo/edk/embedder/test_embedder.cc:63:error:
undefined reference to 'mojo::edk::internal::g_platform_support'
../../third_party/mojo/src/mojo/edk/embedder/test_embedder.cc:66:error:
undefined reference to 'mojo::edk::internal::g_platform_support'
../../third_party/mojo/src/mojo/edk/embedder/test_embedder.cc:67:error:
undefined reference to 'mojo::edk::internal::g_platform_support'
clang:error: linker command failed with exit code 1 (use -v to see invocation)
FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++
-Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro
-Wl,-z,defs -B../../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold
-Wl,--icf=all -pthread -m64 -Wl,-rpath=\$ORIGIN/ -Wl,-rpath-link=
-Wl,--disable-new-dtags -Wl,--export-dynamic -o ./interactive_ui_tests
-Wl,--start-group @./interactive_ui_tests.rsp ./libnet.so ./libskia.so
./libsync.so ./libviews.so ./libui_touch_selection.so ./libchromeos.so
./libcontent.so ./libmojo_system_impl.so ./libgpu.so ./libblink_common.so
./libblink_web.so ./libblink_platform.so ./libgles2_c_lib.so ./liburl.so
./libv8.so ./libcc_blink.so ./libbase.so ./libbase_i18n.so ./libicui18n.so
./libicuuc.so ./libcrcrypto.so ./libprotobuf_lite.so ./libboringssl.so
./libnet_with_v8.so ./libstorage_common.so ./libui_base.so ./libplatform.so
./libevents_base.so ./libgfx.so ./libgeometry.so ./libui_base_ime.so
./libevents.so ./libgesture_detection.so ./libdevices.so ./libgfx_x11.so
./libgl_wrapper.so ./libx11_window.so ./libmojo_environment_impl.so
./libscheduler.so ./libcc.so ./libcc_surfaces.so ./libgles2_implementation.so
./libgl_in_process_context.so ./libgles2_utils.so ./libmedia.so ./libmojo.so
./libmojo_common_lib.so ./libmessage_pump.so ./libppapi_host.so
./libppapi_proxy.so ./libipc.so ./libppapi_shared.so ./libstorage_browser.so
./libcompositor.so ./libsurface.so ./libaura.so ./libwm.so ./libgin.so
./libprefs.so ./libnative_theme.so ./libkeyed_service_core.so ./libsql.so
./libwebdata_common.so ./libsessions.so ./libprotocol.so
./libcloud_policy_proto_generated_compile.so ./libpolicy_component.so
./libproto.so ./libcommon.so ./libaccessibility.so ./libgfx_ipc.so
./libmessage_center.so ./libdevice_event_log.so ./libdevice_core.so ./libdbus.so
./liburl_matcher.so ./libbluetooth.so ./libkeyboard_with_content.so
./libprinting.so ./libkeyed_service_content.so ./libonc.so
./libshared_memory_support.so ./libgcm.so ./libchrome_apps.so ./libash.so
./libkeyboard.so ./libx11_events_platform.so ./libwebview.so ./libsnapshot.so
./libbrowser_ui_views.so ./libweb_dialogs.so ./libwallpaper.so
./libash_with_content.so ./liblogin.so ./libcore.so ./libuser_manager.so
./libownership.so ./libproxy_config.so ./libapp_list.so ./libui_chromeos.so
./libdisplay.so ./libfile_manager.so ./libcaptive_portal.so
./libdomain_reliability.so ./libchromium_sqlite3.so ./libstartup_tracing.so
./libuser_prefs.so ./libshell_dialogs.so ./libmidi.so ./libtranslator.so
-Wl,--end-group  -ldl -lXtst -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lrt
-lglib-2.0 -lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4 -lfontconfig -lX11
-lXcomposite -lXcursor -lXdamage -lXext -lXfixes -lXi -lXrender -lexpat -lm
-ldbus-1 -lpthread -lXrandr -lfreetype 
../../third_party/mojo/src/mojo/edk/embedder/embedder.cc:132:error: undefined
reference to 'mojo::edk::internal::g_core'
../../third_party/mojo/src/mojo/edk/embedder/entrypoints.cc:33:error: undefined
reference to 'mojo::edk::internal::g_core'
../../third_party/mojo/src/mojo/edk/embedder/entrypoints.cc:39:error: undefined
reference to 'mojo::edk::internal::g_core'
../../third_party/mojo/src/mojo/edk/embedder/entrypoints.cc:48:error: undefined
reference to 'mojo::edk::internal::g_core'
../../third_party/mojo/src/mojo/edk/embedder/test_embedder.cc:63:error:
undefined reference to 'mojo::edk::internal::g_platform_support'
../../third_party/mojo/src/mojo/edk/embedder/test_embedder.cc:66:error:
undefined reference to 'mojo::edk::internal::g_platform_support'
../../third_party/mojo/src/mojo/edk/embedder/test_embedder.cc:67:error:
undefined reference to 'mojo::edk::internal::g_platform_support'
clang:error: linker command failed with exit code 1 (use -v to see invocation)
FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++
-Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro
-Wl,-z,defs -B../../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold
-Wl,--icf=all -pthread -m64 -Wl,-rpath=\$ORIGIN/ -Wl,-rpath-link=
-Wl,--disable-new-dtags -Wl,--export-dynamic -o ./unit_tests -Wl,--start-group
@./unit_tests.rsp ./libnet.so ./libskia.so ./libgl_wrapper.so ./libv8.so
./libwm.so ./libdevices.so ./libdbus.so ./libviews.so ./libbase.so
./libbase_i18n.so ./libicui18n.so ./libicuuc.so ./libprefs.so ./libui_base.so
./libplatform.so ./libevents_base.so ./libgfx.so ./libgeometry.so ./liburl.so
./libprotobuf_lite.so ./libcrcrypto.so ./libboringssl.so ./libnative_theme.so
./libkeyed_service_core.so ./libsql.so ./libwebdata_common.so ./libsessions.so
./libprotocol.so ./libcontent.so ./libmojo_system_impl.so ./libgpu.so
./libsync.so ./libcloud_policy_proto_generated_compile.so
./libpolicy_component.so ./libproto.so ./libmojo_environment_impl.so ./libipc.so
./libcommon.so ./libgin.so ./libppapi_shared.so ./libaccessibility.so
./libgfx_ipc.so ./libmessage_center.so ./libblink_common.so ./libblink_web.so
./libblink_platform.so ./libgles2_c_lib.so ./libmedia.so
./libdevice_event_log.so ./libdevice_core.so ./libchromeos.so
./liburl_matcher.so ./libbluetooth.so ./libkeyboard_with_content.so
./libprinting.so ./libkeyed_service_content.so ./libonc.so
./libshared_memory_support.so ./libgcm.so ./libstorage_common.so
./libui_base_ime.so ./libstorage_browser.so ./libchrome_apps.so ./libcc.so
./libppapi_host.so ./libaura.so ./libcompositor.so ./libevents.so ./libash.so
./libkeyboard.so ./libx11_events_platform.so ./libgfx_x11.so ./libwebview.so
./libgesture_detection.so ./libsnapshot.so ./libbrowser_ui_views.so
./libnet_with_v8.so ./libsurface.so ./libweb_dialogs.so ./libppapi_proxy.so
./libwallpaper.so ./libash_with_content.so ./liblogin.so ./libcore.so
./libuser_manager.so ./libownership.so ./libproxy_config.so ./libapp_list.so
./libui_chromeos.so ./libdisplay.so ./libfile_manager.so ./libcaptive_portal.so
./libdomain_reliability.so ./libchromium_sqlite3.so ./libstartup_tracing.so
./libuser_prefs.so ./libshell_dialogs.so ./libmidi.so ./libmojo_common_lib.so
./libmessage_pump.so ./libgles2_implementation.so ./libgles2_utils.so
./libtranslator.so ./libcc_blink.so ./libx11_window.so ./libscheduler.so
./libcc_surfaces.so ./libgl_in_process_context.so ./libmojo.so -Wl,--end-group 
-ldl -ldbus-1 -lpthread -lrt -lX11 -lXcomposite -lXcursor -lXdamage -lXext
-lXfixes -lXi -lXrender -lXtst -lnss3 -lnssutil3 -lsmime3 -lplds4 -lplc4 -lnspr4
-lexpat -lXrandr -lm -lfontconfig -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0
-lglib-2.0 -lfreetype 
../../third_party/mojo/src/mojo/edk/embedder/embedder.cc:132:error: undefined
reference to 'mojo::edk::internal::g_core'
../../third_party/mojo/src/mojo/edk/embedder/entrypoints.cc:33:error: undefined
reference to 'mojo::edk::internal::g_core'
../../third_party/mojo/src/mojo/edk/embedder/entrypoints.cc:39:error: undefined
reference to 'mojo::edk::internal::g_core'
../../third_party/mojo/src/mojo/edk/embedder/entrypoints.cc:48:error: undefined
reference to 'mojo::edk::internal::g_core'
../../third_party/mojo/src/mojo/edk/embedder/test_embedder.cc:63:error:
undefined reference to 'mojo::edk::internal::g_platform_support'
../../third_party/mojo/src/mojo/edk/embedder/test_embedder.cc:66:error:
undefined reference to 'mojo::edk::internal::g_platform_support'
../../third_party/mojo/src/mojo/edk/embedder/test_embedder.cc:67:error:
undefined reference to 'mojo::edk::internal::g_platform_support'
clang:error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed..

[Ben Goodger (Google), 2015-11-06 03:51:24]

Description was changed from

==========
Allow Chrome to bind an Application request from mojo_runner.

When chrome.exe is run from mojo_runner, block on startup until the
InterfaceRequest<Application> is bound, and a message loop is run until the
runner's shell sends Initialize().

R=sky@chromium.org
http://crbug.com/548694

Committed: https://crrev.com/2b4a62d4282df3fe69696925a6b84fdca1df2d0f
Cr-Commit-Position: refs/heads/master@{#358145}
==========

to

==========
Allow Chrome to bind an Application request from mojo_runner.

When chrome.exe is run from mojo_runner, block on startup until the
InterfaceRequest<Application> is bound, and a message loop is run until the
runner's shell sends Initialize().

R=sky@chromium.org
http://crbug.com/548694

Committed: https://crrev.com/2b4a62d4282df3fe69696925a6b84fdca1df2d0f
Cr-Commit-Position: refs/heads/master@{#358145}
==========

[Ben Goodger (Google), 2015-11-09 20:15:39]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2015-11-09 20:15:39]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1423063004/#ps140001
(title: ".")

[commit-bot: I haz the power, 2015-11-09 20:16:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1423063004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1423063004/140001

[commit-bot: I haz the power, 2015-11-09 21:49:13]

Committed patchset #9 (id:140001)

[commit-bot: I haz the power, 2015-11-09 21:50:03]

Patchset 9 (id:??) landed as
https://crrev.com/0cc0be91569cbc1942803b01a5c8001f58e48328
Cr-Commit-Position: refs/heads/master@{#358668}