Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1858)

Unified Diff: content/public/common/BUILD.gn

Issue 1423043002: Fix missing dependencies for //components/crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: double-sigh. Add v8 config to content_descriptors target Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/crash/core/browser/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/common/BUILD.gn
diff --git a/content/public/common/BUILD.gn b/content/public/common/BUILD.gn
index 8bab029fc27d115506be7ffaf71d49041734cf10..5328de0231d6a0b7e316d89676dcba5b0cb2fb38 100644
--- a/content/public/common/BUILD.gn
+++ b/content/public/common/BUILD.gn
@@ -27,6 +27,15 @@ source_set("result_codes") {
]
}
+# This target allows other targets to depend on content_descriptors.h which is
+# a header-only dependency, without bringing in all of content.
+source_set("content_descriptors") {
+ sources = [
+ "content_descriptors.h",
+ ]
+ public_configs = [ "//v8:external_startup_data" ]
+}
+
# Forces static linking for targets using the static_switches constants, even
# in the component build. This config makes it impossible to use the static
# switches target and use the rest of content at the same time, because the
« no previous file with comments | « components/crash/core/browser/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698