components/crash/content/browser/BUILD.gn - Issue 1423043002: Fix missing dependencies for //components/crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crash/content/browser/BUILD.gn

Issue 1423043002: Fix missing dependencies for //components/crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: double-sigh. Add v8 config to content_descriptors target Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/crash/content/browser/BUILD.gn

diff --git a/components/crash/content/browser/BUILD.gn b/components/crash/content/browser/BUILD.gn

index 44323574d9f890668de6ca8da7d47ed8addc7ee4..b3a79482dcdf448e222cef3401724c54ef3291a9 100644

--- a/components/crash/content/browser/BUILD.gn

+++ b/components/crash/content/browser/BUILD.gn

@@ -14,6 +14,7 @@ source_set("browser") {

deps = [

"//base",

+ "//breakpad:client",

"//components/crash/content/app",

"//content/public/browser",

"//content/public/common",

@@ -27,7 +28,10 @@ source_set("browser") {

"crash_handler_host_linux.cc",

"crash_handler_host_linux.h",

]

- deps += [ "//breakpad:client" ]

+ deps += [

+ "//breakpad:client",

+ "//components/crash/content/app:app_non_mac",

+ ]

}

# This is not in the GYP build but this target includes breakpad client

« no previous file with comments | « components/crash/content/app/BUILD.gn ('k') | components/crash/core/browser/BUILD.gn » ('j') | no next file with comments »