Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: .gn

Issue 1423043002: Fix missing dependencies for //components/crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: double-sigh. Add v8 config to content_descriptors target Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/crash/content/app/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: .gn
diff --git a/.gn b/.gn
index 69b64de7b7521c407ac602986ac125511b52354a..53d942363647bf1181249a5ab5b680d0943bc9eb 100644
--- a/.gn
+++ b/.gn
@@ -58,8 +58,7 @@ check_targets = [
"//components/content_settings/*",
"//components/cookie_config/*",
"//components/copresence/*",
-
- #"//components/crash/*", TODO(brettw) once conflicting patches are landed.
+ "//components/crash/*",
"//components/cronet/*",
"//components/crx_file/*",
"//components/data_reduction_proxy/*",
« no previous file with comments | « no previous file | components/crash/content/app/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698