Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: components/crash/content/browser/BUILD.gn

Issue 1423043002: Fix missing dependencies for //components/crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge to #356384, update w/ review feedback Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 if (is_android) { 5 if (is_android) {
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 } 7 }
8 8
9 source_set("browser") { 9 source_set("browser") {
10 sources = [ 10 sources = [
11 "crash_dump_manager_android.cc", 11 "crash_dump_manager_android.cc",
12 "crash_dump_manager_android.h", 12 "crash_dump_manager_android.h",
13 ] 13 ]
14 14
15 deps = [ 15 deps = [
16 "//base", 16 "//base",
17 "//breakpad:client",
17 "//components/crash/content/app", 18 "//components/crash/content/app",
18 "//content/public/browser", 19 "//content/public/browser",
19 "//content/public/common", 20 "//content/public/common",
20 ] 21 ]
21 22
22 if (is_linux || is_android) { 23 if (is_linux || is_android) {
23 set_sources_assignment_filter([]) 24 set_sources_assignment_filter([])
24 25
25 # Want this file on both Linux and Android. 26 # Want this file on both Linux and Android.
26 sources += [ 27 sources += [
27 "crash_handler_host_linux.cc", 28 "crash_handler_host_linux.cc",
28 "crash_handler_host_linux.h", 29 "crash_handler_host_linux.h",
29 ] 30 ]
30 deps += [ "//breakpad:client" ] 31 deps += [
32 "//breakpad:client",
33 "//components/crash/content/app:app_non_mac",
34 ]
31 } 35 }
32 36
33 # This is not in the GYP build but this target includes breakpad client 37 # This is not in the GYP build but this target includes breakpad client
34 # headers, so add the dependency here. 38 # headers, so add the dependency here.
35 if (is_posix && !is_ios) { 39 if (is_posix && !is_ios) {
36 configs += [ "//breakpad:client_config" ] 40 configs += [ "//breakpad:client_config" ]
37 public_configs = [ "//breakpad:client_config" ] 41 public_configs = [ "//breakpad:client_config" ]
38 } 42 }
39 } 43 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698