Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: components/crash.gypi

Issue 1423043002: Fix missing dependencies for //components/crash. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merge to #356384, update w/ review feedback Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 # GN version: //components/crash/core/browser 8 # GN version: //components/crash/core/browser
9 'target_name': 'crash_core_browser', 9 'target_name': 'crash_core_browser',
10 'type': 'static_library', 10 'type': 'static_library',
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 'crash/content/app/breakpad_linux.h', 134 'crash/content/app/breakpad_linux.h',
135 'crash/content/app/breakpad_linux_impl.h', 135 'crash/content/app/breakpad_linux_impl.h',
136 'crash/content/app/breakpad_win.cc', 136 'crash/content/app/breakpad_win.cc',
137 'crash/content/app/breakpad_win.h', 137 'crash/content/app/breakpad_win.h',
138 'crash/content/app/hard_error_handler_win.cc', 138 'crash/content/app/hard_error_handler_win.cc',
139 'crash/content/app/hard_error_handler_win.h', 139 'crash/content/app/hard_error_handler_win.h',
140 ], 140 ],
141 'dependencies': [ 141 'dependencies': [
142 'crash_component_lib', 142 'crash_component_lib',
143 '../base/base.gyp:base', 143 '../base/base.gyp:base',
144 '../content/content.gyp:content_common',
144 ], 145 ],
145 'defines': ['CRASH_IMPLEMENTATION'], 146 'defines': ['CRASH_IMPLEMENTATION'],
146 'conditions': [ 147 'conditions': [
147 ['OS=="win"', { 148 ['OS=="win"', {
148 'dependencies': [ 149 'dependencies': [
149 '../breakpad/breakpad.gyp:breakpad_handler', 150 '../breakpad/breakpad.gyp:breakpad_handler',
150 '../breakpad/breakpad.gyp:breakpad_sender', 151 '../breakpad/breakpad.gyp:breakpad_sender',
151 '../sandbox/sandbox.gyp:sandbox', 152 '../sandbox/sandbox.gyp:sandbox',
152 ], 153 ],
153 }], 154 }],
(...skipping 10 matching lines...) Expand all
164 # Need 'target_conditions' to override default filename_rules to inc lude 165 # Need 'target_conditions' to override default filename_rules to inc lude
165 # the files on Android. 166 # the files on Android.
166 ['OS=="android"', { 167 ['OS=="android"', {
167 'sources/': [ 168 'sources/': [
168 ['include', '^crash/content/app/breakpad_linux\\.cc$'], 169 ['include', '^crash/content/app/breakpad_linux\\.cc$'],
169 ], 170 ],
170 }], 171 }],
171 ], 172 ],
172 }, 173 },
173 { 174 {
174 # Note: if you depend on this target, you need to either link in
175 # content.gyp:content_common, or add
176 # content/public/common/content_switches.cc to your sources.
177 #
178 # GN version: //components/crash/content/app 175 # GN version: //components/crash/content/app
179 176
180 # TODO(mark): https://crbug.com/466890: merge this target with 177 # TODO(mark): https://crbug.com/466890: merge this target with
181 # crash_component_non_mac. 178 # crash_component_non_mac.
182 # 179 #
183 # Most of this target is actually in its dependency, 180 # Most of this target is actually in its dependency,
184 # crash_component_non_mac. See the comment in that target for an 181 # crash_component_non_mac. See the comment in that target for an
185 # explanation for the split. The split is temporary and the two target s 182 # explanation for the split. The split is temporary and the two target s
186 # will be unified again soon. 183 # will be unified again soon.
187 'target_name': 'crash_component', 184 'target_name': 'crash_component',
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
285 'sources': [ 282 'sources': [
286 'crash/content/tools/crash_service.cc', 283 'crash/content/tools/crash_service.cc',
287 'crash/content/tools/crash_service.h', 284 'crash/content/tools/crash_service.h',
288 ], 285 ],
289 }, 286 },
290 ], 287 ],
291 }], 288 }],
292 ['OS=="win" and target_arch=="ia32"', { 289 ['OS=="win" and target_arch=="ia32"', {
293 'targets': [ 290 'targets': [
294 { 291 {
295 # Note: if you depend on this target, you need to either link in
296 # content.gyp:content_common, or add
297 # content/public/common/content_switches.cc to your sources.
298 'target_name': 'breakpad_win64', 292 'target_name': 'breakpad_win64',
299 'type': 'static_library', 293 'type': 'static_library',
300 'sources': [ 294 'sources': [
301 'crash/content/app/breakpad_linux.cc', 295 'crash/content/app/breakpad_linux.cc',
302 'crash/content/app/breakpad_linux.h', 296 'crash/content/app/breakpad_linux.h',
303 'crash/content/app/breakpad_linux_impl.h', 297 'crash/content/app/breakpad_linux_impl.h',
304 'crash/content/app/breakpad_mac.h', 298 'crash/content/app/breakpad_mac.h',
305 'crash/content/app/breakpad_mac.mm', 299 'crash/content/app/breakpad_mac.mm',
306 'crash/content/app/breakpad_win.cc', 300 'crash/content/app/breakpad_win.cc',
307 'crash/content/app/breakpad_win.h', 301 'crash/content/app/breakpad_win.h',
308 # TODO(siggi): test the x64 version too. 302 # TODO(siggi): test the x64 version too.
309 'crash/content/app/crash_keys_win.cc', 303 'crash/content/app/crash_keys_win.cc',
310 'crash/content/app/crash_keys_win.h', 304 'crash/content/app/crash_keys_win.h',
311 'crash/content/app/crash_reporter_client.cc', 305 'crash/content/app/crash_reporter_client.cc',
312 'crash/content/app/crash_reporter_client.h', 306 'crash/content/app/crash_reporter_client.h',
313 'crash/content/app/hard_error_handler_win.cc', 307 'crash/content/app/hard_error_handler_win.cc',
314 'crash/content/app/hard_error_handler_win.h', 308 'crash/content/app/hard_error_handler_win.h',
315 ], 309 ],
316 'defines': [ 310 'defines': [
317 'COMPILE_CONTENT_STATICALLY', 311 'COMPILE_CONTENT_STATICALLY',
318 'CRASH_IMPLEMENTATION', 312 'CRASH_IMPLEMENTATION',
319 ], 313 ],
320 'dependencies': [ 314 'dependencies': [
321 '../base/base.gyp:base_win64', 315 '../base/base.gyp:base_win64',
322 '../breakpad/breakpad.gyp:breakpad_handler_win64', 316 '../breakpad/breakpad.gyp:breakpad_handler_win64',
323 '../breakpad/breakpad.gyp:breakpad_sender_win64', 317 '../breakpad/breakpad.gyp:breakpad_sender_win64',
318 '../content/content.gyp:content_common',
324 '../sandbox/sandbox.gyp:sandbox_win64', 319 '../sandbox/sandbox.gyp:sandbox_win64',
325 ], 320 ],
326 'configurations': { 321 'configurations': {
327 'Common_Base': { 322 'Common_Base': {
328 'msvs_target_platform': 'x64', 323 'msvs_target_platform': 'x64',
329 }, 324 },
330 }, 325 },
331 }, 326 },
332 { 327 {
333 'target_name': 'breakpad_crash_service_win64', 328 'target_name': 'breakpad_crash_service_win64',
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
397 ], 392 ],
398 }], 393 }],
399 ], 394 ],
400 }, 395 },
401 ], 396 ],
402 }], 397 }],
403 ], 398 ],
404 }], 399 }],
405 ], 400 ],
406 } 401 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698