include/core/SkPostConfig.h - Issue 1423013004: For BUILD.public, let SkPreConfig.h set SK_RELEASE based on NDEBUG.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkPostConfig.h

Issue 1423013004: For BUILD.public, let SkPreConfig.h set SK_RELEASE based on NDEBUG. (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/core/SkPostConfig.h

diff --git a/include/core/SkPostConfig.h b/include/core/SkPostConfig.h

index 76f504f4592a7565934de72bd82abade588cca69..b845fa48c9ee6d6535fc0b15d3fe78db9f4d6db6 100644

--- a/include/core/SkPostConfig.h

+++ b/include/core/SkPostConfig.h

@@ -148,7 +148,16 @@

#endif

#ifndef SK_ALWAYSBREAK

-# ifdef SK_DEBUG

+# if defined(GOOGLE3)

+# include "base/examine_stack.h"

+# define SK_ALWAYSBREAK(cond) do { \

+ if (cond) break; \

+ SkNO_RETURN_HINT(); \

+ SkDebugf("%s:%d: failed assertion \"%s\"\n", __FILE__, __LINE__, #cond); \

+ DumpStackTrace(0, DebugWriteToStderr, NULL); \

mtklein 2015/10/28 19:09:07 Think we can just forward-declare this instead of

+ SK_CRASH(); \

+ } while (false)

+# elif defined(SK_DEBUG)

# define SK_ALWAYSBREAK(cond) do { \

if (cond) break; \

SkNO_RETURN_HINT(); \

« no previous file with comments | « BUILD.public ('k') | tests/AtomicTest.cpp » ('j') | no next file with comments »