For BUILD.public, let SkPreConfig.h set SK_RELEASE based on NDEBUG.

For BUILD.public, let SkPreConfig.h set SK_RELEASE based on NDEBUG.

Use DumpStackTrace in SkASSERT in GOOGLE3.

There are extra assertions enabled in debug mode that cause RecordDraw_TextBounds to fail.

New include causes a naming conflict with global name "base".

Corresponding internal cl/106495354

No public API changes.

TBR=reed@google.com
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/8a3760f8b2ce8ded477ba90dd8e1522b1df441b8

[dogben, 2015-10-28 18:29:09]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-28 18:29:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1423013004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1423013004/1

[dogben, 2015-10-28 18:32:12]

Description was changed from

==========
For BUILD.public, let SkPreConfig.h set SK_RELEASE based on NDEBUG.

Use DumpStackTrace in SkASSERT in GOOGLE3.

BUG=skia:
==========

to

==========
For BUILD.public, let SkPreConfig.h set SK_RELEASE based on NDEBUG.

Use DumpStackTrace in SkASSERT in GOOGLE3.

There are extra assertions enabled in debug mode that cause
RecordDraw_TextBounds to fail.

New include causes a naming conflict with global name "base".

BUG=skia:
==========

[commit-bot: I haz the power, 2015-10-28 18:40:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-28 18:40:54]

Dry run: This issue passed the CQ dry run.

[dogben, 2015-10-28 18:59:18]

benjaminwagner@google.com changed reviewers:
+ mtklein@google.com

[dogben, 2015-10-28 18:59:19]

I'm unsure if the addition of stack traces is a positive change. I needed to
enable stack traces in order to figure out where dm was segfaulting, and I
figured it would be useful again in the future.

[dogben, 2015-10-28 19:02:51]

Patchset #1 (id:1) has been deleted

[dogben, 2015-10-28 19:03:01]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-28 19:03:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1423013004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1423013004/20001

[mtklein, 2015-10-28 19:09:07]

https://codereview.chromium.org/1423013004/diff/20001/include/core/SkPostConf...
File include/core/SkPostConfig.h (right):

https://codereview.chromium.org/1423013004/diff/20001/include/core/SkPostConf...
include/core/SkPostConfig.h:157: DumpStackTrace(0, DebugWriteToStderr, NULL); \
Think we can just forward-declare this instead of including base/examine_stack.h
to avoid polluting the global namespace with `base`?

[commit-bot: I haz the power, 2015-10-28 19:16:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-28 19:16:47]

Dry run: This issue passed the CQ dry run.

[dogben, 2015-10-29 15:20:31]

The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-29 15:20:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1423013004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1423013004/40001

[commit-bot: I haz the power, 2015-10-29 15:32:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 15:32:01]

Dry run: This issue passed the CQ dry run.

[dogben, 2015-10-29 15:35:52]

Description was changed from

==========
For BUILD.public, let SkPreConfig.h set SK_RELEASE based on NDEBUG.

Use DumpStackTrace in SkASSERT in GOOGLE3.

There are extra assertions enabled in debug mode that cause
RecordDraw_TextBounds to fail.

New include causes a naming conflict with global name "base".

BUG=skia:
==========

to

==========
For BUILD.public, let SkPreConfig.h set SK_RELEASE based on NDEBUG.

Use DumpStackTrace in SkASSERT in GOOGLE3.

There are extra assertions enabled in debug mode that cause
RecordDraw_TextBounds to fail.

New include causes a naming conflict with global name "base".

Corresponding internal cl/106495354

BUG=skia:
==========

[dogben, 2015-10-29 15:36:09]

PTAL

[mtklein, 2015-10-29 19:53:21]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-10-29 19:53:21]

lgtm

[commit-bot: I haz the power, 2015-10-29 19:53:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1423013004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1423013004/40001

[commit-bot: I haz the power, 2015-10-29 19:54:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 19:54:37]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[mtklein, 2015-10-29 19:55:32]

(Let's add this:

No public API changes.
TBR=reed@google.com
)

[dogben, 2015-10-29 20:39:32]

Description was changed from

==========
For BUILD.public, let SkPreConfig.h set SK_RELEASE based on NDEBUG.

Use DumpStackTrace in SkASSERT in GOOGLE3.

There are extra assertions enabled in debug mode that cause
RecordDraw_TextBounds to fail.

New include causes a naming conflict with global name "base".

Corresponding internal cl/106495354

BUG=skia:
==========

to

==========
For BUILD.public, let SkPreConfig.h set SK_RELEASE based on NDEBUG.

Use DumpStackTrace in SkASSERT in GOOGLE3.

There are extra assertions enabled in debug mode that cause
RecordDraw_TextBounds to fail.

New include causes a naming conflict with global name "base".

Corresponding internal cl/106495354

No public API changes.

TBR=reed@google.com
BUG=skia:
==========

[dogben, 2015-10-29 20:39:43]

The CQ bit was checked by benjaminwagner@google.com

[commit-bot: I haz the power, 2015-10-29 20:39:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1423013004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1423013004/40001

[commit-bot: I haz the power, 2015-10-29 20:40:32]

Committed patchset #2 (id:40001) as
https://skia.googlesource.com/skia/+/8a3760f8b2ce8ded477ba90dd8e1522b1df441b8