Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 1423013004: For BUILD.public, let SkPreConfig.h set SK_RELEASE based on NDEBUG. (Closed)

Created:
5 years, 1 month ago by dogben
Modified:
5 years, 1 month ago
Reviewers:
mtklein
CC:
jcgregorio, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

For BUILD.public, let SkPreConfig.h set SK_RELEASE based on NDEBUG. Use DumpStackTrace in SkASSERT in GOOGLE3. There are extra assertions enabled in debug mode that cause RecordDraw_TextBounds to fail. New include causes a naming conflict with global name "base". Corresponding internal cl/106495354 No public API changes. TBR=reed@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/8a3760f8b2ce8ded477ba90dd8e1522b1df441b8

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Replace #include with forward-declare. Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -12 lines) Patch
M BUILD.public View 6 chunks +6 lines, -6 lines 0 comments Download
M include/core/SkPostConfig.h View 1 1 chunk +12 lines, -1 line 0 comments Download
M tools/BUILD.public.expected View 1 6 chunks +6 lines, -5 lines 0 comments Download
M tools/BUILD_simulator.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 29 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423013004/1
5 years, 1 month ago (2015-10-28 18:29:14 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-28 18:40:54 UTC) #5
dogben
I'm unsure if the addition of stack traces is a positive change. I needed to ...
5 years, 1 month ago (2015-10-28 18:59:19 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423013004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423013004/20001
5 years, 1 month ago (2015-10-28 19:03:06 UTC) #10
mtklein
https://codereview.chromium.org/1423013004/diff/20001/include/core/SkPostConfig.h File include/core/SkPostConfig.h (right): https://codereview.chromium.org/1423013004/diff/20001/include/core/SkPostConfig.h#newcode157 include/core/SkPostConfig.h:157: DumpStackTrace(0, DebugWriteToStderr, NULL); \ Think we can just forward-declare ...
5 years, 1 month ago (2015-10-28 19:09:07 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-28 19:16:47 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423013004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423013004/40001
5 years, 1 month ago (2015-10-29 15:20:42 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-29 15:32:01 UTC) #17
dogben
PTAL
5 years, 1 month ago (2015-10-29 15:36:09 UTC) #19
mtklein
lgtm
5 years, 1 month ago (2015-10-29 19:53:21 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423013004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423013004/40001
5 years, 1 month ago (2015-10-29 19:53:28 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/3576)
5 years, 1 month ago (2015-10-29 19:54:37 UTC) #24
mtklein
(Let's add this: No public API changes. TBR=reed@google.com )
5 years, 1 month ago (2015-10-29 19:55:32 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1423013004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1423013004/40001
5 years, 1 month ago (2015-10-29 20:39:52 UTC) #28
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 20:40:32 UTC) #29
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://skia.googlesource.com/skia/+/8a3760f8b2ce8ded477ba90dd8e1522b1df441b8

Powered by Google App Engine
This is Rietveld 408576698