Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Unified Diff: src/pipe/SkGPipeRead.cpp

Issue 14230022: Fixes for piping bitmaps with encoded data. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Add some asserts and comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkOrderedWriteBuffer.cpp ('k') | src/pipe/SkGPipeWrite.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/pipe/SkGPipeRead.cpp
diff --git a/src/pipe/SkGPipeRead.cpp b/src/pipe/SkGPipeRead.cpp
index f47f3bfe657875d8fb8d16ada4294f06c3cf7162..3f9ce12db76c7b7144eb09a6ff19188910769c53 100644
--- a/src/pipe/SkGPipeRead.cpp
+++ b/src/pipe/SkGPipeRead.cpp
@@ -124,7 +124,12 @@ public:
}
}
+ /**
+ * Add a bitmap to the array of bitmaps, or replace an existing one.
+ * This is only used when in cross process mode without a shared heap.
+ */
void addBitmap(int index) {
+ SkASSERT(shouldFlattenBitmaps(fFlags));
SkBitmap* bm;
if(fBitmaps.count() == index) {
bm = SkNEW(SkBitmap);
@@ -132,14 +137,16 @@ public:
} else {
bm = fBitmaps[index];
}
- bm->unflatten(*fReader);
+ fReader->readBitmap(bm);
}
/**
* Override of SkBitmapHeapReader, so that SkOrderedReadBuffer can use
- * these SkBitmaps for bitmap shaders.
+ * these SkBitmaps for bitmap shaders. Used only in cross process mode
+ * without a shared heap.
*/
virtual SkBitmap* getBitmap(int32_t index) const SK_OVERRIDE {
+ SkASSERT(shouldFlattenBitmaps(fFlags));
return fBitmaps[index];
}
@@ -154,7 +161,12 @@ public:
this->updateReader();
}
+ /**
+ * Access the shared heap. Only used in the case when bitmaps are not
+ * flattened.
+ */
SkBitmapHeap* getSharedHeap() const {
+ SkASSERT(!shouldFlattenBitmaps(fFlags));
return fSharedHeap;
}
@@ -772,12 +784,14 @@ SkGPipeState::~SkGPipeState() {
SkGPipeReader::SkGPipeReader() {
fCanvas = NULL;
fState = NULL;
+ fProc = NULL;
}
SkGPipeReader::SkGPipeReader(SkCanvas* target) {
fCanvas = NULL;
this->setCanvas(target);
fState = NULL;
+ fProc = NULL;
}
void SkGPipeReader::setCanvas(SkCanvas *target) {
@@ -805,6 +819,7 @@ SkGPipeReader::Status SkGPipeReader::playback(const void* data, size_t length,
const ReadProc* table = gReadTable;
SkOrderedReadBuffer reader(data, length);
+ reader.setBitmapDecoder(fProc);
SkCanvas* canvas = fCanvas;
Status status = kEOF_Status;
« no previous file with comments | « src/core/SkOrderedWriteBuffer.cpp ('k') | src/pipe/SkGPipeWrite.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698