Issue 14230011: [NaCl SDK] Pin interfaces to nacl_io

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14230011: [NaCl SDK] Pin interfaces to nacl_io (Closed)

Created:
7 years, 8 months ago by binji

Modified:
7 years, 8 months ago

Reviewers:
noelallen1

CC:
chromium-reviews, Sam Clegg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[NaCl SDK] Pin pepper interfaces in nacl_io. Because we specify the desired methods directly, there is no drawback to specifying the interface versions. One huge benefit is being able to build with a newer SDK on an older chrome -- in this case, pinning PPB_FILEREF_INTERFACE to version 1.0 means that we can use nacl_io from the pepper_28 SDK to run on Chrome stable (version 26). BUG=none R=noelallen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194456

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -10 lines)			Patch
	M	native_client_sdk/src/libraries/nacl_io/pepper/all_interfaces.h	View		4 chunks	+11 lines, -10 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

noelallen1

lgtm https://codereview.chromium.org/14230011/diff/1/native_client_sdk/src/libraries/nacl_io/pepper/all_interfaces.h File native_client_sdk/src/libraries/nacl_io/pepper/all_interfaces.h (right): https://codereview.chromium.org/14230011/diff/1/native_client_sdk/src/libraries/nacl_io/pepper/all_interfaces.h#newcode26 native_client_sdk/src/libraries/nacl_io/pepper/all_interfaces.h:26: PPB_DIRECTORYREADER_DEV_INTERFACE_0_6) Here or as a separate CL, we ...

7 years, 8 months ago (2013-04-16 21:06:01 UTC) #2

binji

Committed patchset #1 manually as r194456 (presubmit successful).

7 years, 8 months ago (2013-04-16 21:17:22 UTC) #3

Message was sent while issue was closed.

filed http://crbug.com/232076

Expand Messages | Collapse Messages