Change the function name to match downstream

Change the function name to match downstream.

Also, move some of the method definitions to .cc file.

BUG=540061
Committed: https://crrev.com/809788548c6b3bf710f78d348af83a4fff45a2bc
Cr-Commit-Position: refs/heads/master@{#359207}

[tbansal1, 2015-11-10 19:15:20]

Description was changed from

==========
Change the function name to match downstream

BUG=
==========

to

==========
Change the function name to match downstream.

Also, move some of the method definitions to .cc file. 

BUG=540061
==========

[tbansal1, 2015-11-10 19:15:37]

tbansal@chromium.org changed reviewers:
+ sclittle@chromium.org

[tbansal1, 2015-11-10 19:15:38]

sclittle: PTAL. thanks.

[sclittle, 2015-11-10 19:21:57]

lgtm % a few nits

https://codereview.chromium.org/1422973004/diff/1/chrome/browser/android/data...
File chrome/browser/android/data_usage/external_data_use_observer.cc (right):

https://codereview.chromium.org/1422973004/diff/1/chrome/browser/android/data...
chrome/browser/android/data_usage/external_data_use_observer.cc:395: return
(label == other.label && connection_type == other.connection_type &&
optional nit: parentheses aren't necessary here.

https://codereview.chromium.org/1422973004/diff/1/chrome/browser/android/data...
File chrome/browser/android/data_usage/external_data_use_observer.h (right):

https://codereview.chromium.org/1422973004/diff/1/chrome/browser/android/data...
chrome/browser/android/data_usage/external_data_use_observer.h:109: virtual
~DataUseReportKey();
nit: this doesn't have to be virtual, and the class is simple enough to just
leave out the destructor here if you want.

https://codereview.chromium.org/1422973004/diff/1/chrome/browser/android/data...
chrome/browser/android/data_usage/external_data_use_observer.h:138: virtual
~DataUseReport();
nit: this doesn't have to be virtual either, and could be left out if you want.

https://codereview.chromium.org/1422973004/diff/1/chrome/browser/android/data...
chrome/browser/android/data_usage/external_data_use_observer.h:160: // Prime
numbers are used for multiplication because the number of buckets
nit: Perhaps the justification for using prime numbers and stuff (i.e. this line
and the lines below) should be moved to the implementation of the method? It
seems a bit more relevant there than here.

[tbansal1, 2015-11-11 21:18:38]

https://codereview.chromium.org/1422973004/diff/1/chrome/browser/android/data...
File chrome/browser/android/data_usage/external_data_use_observer.cc (right):

https://codereview.chromium.org/1422973004/diff/1/chrome/browser/android/data...
chrome/browser/android/data_usage/external_data_use_observer.cc:395: return
(label == other.label && connection_type == other.connection_type &&
On 2015/11/10 19:21:57, sclittle wrote:
> optional nit: parentheses aren't necessary here.

Done.

https://codereview.chromium.org/1422973004/diff/1/chrome/browser/android/data...
File chrome/browser/android/data_usage/external_data_use_observer.h (right):

https://codereview.chromium.org/1422973004/diff/1/chrome/browser/android/data...
chrome/browser/android/data_usage/external_data_use_observer.h:109: virtual
~DataUseReportKey();
On 2015/11/10 19:21:57, sclittle wrote:
> nit: this doesn't have to be virtual, and the class is simple enough to just
> leave out the destructor here if you want.

Done.

https://codereview.chromium.org/1422973004/diff/1/chrome/browser/android/data...
chrome/browser/android/data_usage/external_data_use_observer.h:138: virtual
~DataUseReport();
On 2015/11/10 19:21:57, sclittle wrote:
> nit: this doesn't have to be virtual either, and could be left out if you
want.

Done.

https://codereview.chromium.org/1422973004/diff/1/chrome/browser/android/data...
chrome/browser/android/data_usage/external_data_use_observer.h:160: // Prime
numbers are used for multiplication because the number of buckets
On 2015/11/10 19:21:57, sclittle wrote:
> nit: Perhaps the justification for using prime numbers and stuff (i.e. this
line
> and the lines below) should be moved to the implementation of the method? It
> seems a bit more relevant there than here.

Done.

[tbansal1, 2015-11-11 21:18:39]

https://codereview.chromium.org/1422973004/diff/1/chrome/browser/android/data...
File chrome/browser/android/data_usage/external_data_use_observer.cc (right):

https://codereview.chromium.org/1422973004/diff/1/chrome/browser/android/data...
chrome/browser/android/data_usage/external_data_use_observer.cc:395: return
(label == other.label && connection_type == other.connection_type &&
On 2015/11/10 19:21:57, sclittle wrote:
> optional nit: parentheses aren't necessary here.

Done.

https://codereview.chromium.org/1422973004/diff/1/chrome/browser/android/data...
File chrome/browser/android/data_usage/external_data_use_observer.h (right):

https://codereview.chromium.org/1422973004/diff/1/chrome/browser/android/data...
chrome/browser/android/data_usage/external_data_use_observer.h:109: virtual
~DataUseReportKey();
On 2015/11/10 19:21:57, sclittle wrote:
> nit: this doesn't have to be virtual, and the class is simple enough to just
> leave out the destructor here if you want.

Done.

https://codereview.chromium.org/1422973004/diff/1/chrome/browser/android/data...
chrome/browser/android/data_usage/external_data_use_observer.h:138: virtual
~DataUseReport();
On 2015/11/10 19:21:57, sclittle wrote:
> nit: this doesn't have to be virtual either, and could be left out if you
want.

Done.

https://codereview.chromium.org/1422973004/diff/1/chrome/browser/android/data...
chrome/browser/android/data_usage/external_data_use_observer.h:160: // Prime
numbers are used for multiplication because the number of buckets
On 2015/11/10 19:21:57, sclittle wrote:
> nit: Perhaps the justification for using prime numbers and stuff (i.e. this
line
> and the lines below) should be moved to the implementation of the method? It
> seems a bit more relevant there than here.

Done.

[tbansal1, 2015-11-11 21:18:43]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2015-11-11 21:18:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
sclittle@chromium.org
Link to the patchset: https://codereview.chromium.org/1422973004/#ps40001
(title: "Rebased")

[commit-bot: I haz the power, 2015-11-11 21:19:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422973004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422973004/40001

[commit-bot: I haz the power, 2015-11-11 21:30:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-11 21:30:01]

Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tbansal1, 2015-11-11 22:15:58]

The CQ bit was unchecked by tbansal@chromium.org

[tbansal1, 2015-11-11 22:16:06]

The CQ bit was checked by tbansal@chromium.org

[commit-bot: I haz the power, 2015-11-11 22:16:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422973004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422973004/40001

[commit-bot: I haz the power, 2015-11-11 22:39:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-11 22:39:53]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED, no build URL)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED, no build URL)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
no build URL)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, no
build URL)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, no
build URL)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tbansal1, 2015-11-12 00:39:01]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2015-11-12 00:39:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
sclittle@chromium.org
Link to the patchset: https://codereview.chromium.org/1422973004/#ps60001
(title: "gyp mod")

[commit-bot: I haz the power, 2015-11-12 00:41:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422973004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422973004/60001

[commit-bot: I haz the power, 2015-11-12 01:58:31]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-12 20:02:43]

Patchset 4 (id:??) landed as
https://crrev.com/809788548c6b3bf710f78d348af83a4fff45a2bc
Cr-Commit-Position: refs/heads/master@{#359207}