Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1422973002: Fix access check in JSObject::PreventExtensions. (Closed)

Created:
5 years, 1 month ago by neis
Modified:
5 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix access check in JSObject::PreventExtensions. BUG= Committed: https://crrev.com/80bc0803094ec0f593537952b6616718438f053b Cr-Commit-Position: refs/heads/master@{#31573}

Patch Set 1 #

Patch Set 2 : Add a test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M src/objects.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
neis
PTAL
5 years, 1 month ago (2015-10-26 12:15:22 UTC) #3
Toon Verwaest
lgtm
5 years, 1 month ago (2015-10-26 13:53:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422973002/20001
5 years, 1 month ago (2015-10-26 13:56:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-26 15:02:22 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 15:02:41 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/80bc0803094ec0f593537952b6616718438f053b
Cr-Commit-Position: refs/heads/master@{#31573}

Powered by Google App Engine
This is Rietveld 408576698