Add RunnerSuite.{on,is}Debugging properties.

lib/src/runner/load_suite.dart

Index: lib/src/runner/load_suite.dart
diff --git a/lib/src/runner/load_suite.dart b/lib/src/runner/load_suite.dart
index a83177746f0ddd81202ef33bd62b0a1d644e6c34..460e5e8857bc9b56408725f05618fd64ffcd7535 100644
--- a/lib/src/runner/load_suite.dart
+++ b/lib/src/runner/load_suite.dart
@@ -12,6 +12,7 @@ import '../../test.dart';
 import '../backend/group.dart';
 import '../backend/invoker.dart';
 import '../backend/metadata.dart';
+import '../backend/suite.dart';
 import '../backend/test.dart';
 import '../backend/test_platform.dart';
 import '../utils.dart';
@@ -33,7 +34,11 @@ import 'vm/environment.dart';
 /// a normal test body, this logic isn't run until [LiveTest.run] is called. The
 /// suite itself is returned by [suite] once it's avaialble, but any errors or
 /// prints will be emitted through the running [LiveTest].
-class LoadSuite extends RunnerSuite {
+class LoadSuite extends Suite implements RunnerSuite {
+  final environment = const VMEnvironment();

[kevmoo, 2015/11/06 18:13:56]

nit - might as well be getters – don't add to instance size

[nweiz, 2015/11/16 20:27:00]

The implementation can easily determine that final fields with constant values
aren't going to change. It can represent them internally however it thinks will
be most efficient, if the VM developers believe that representation will make a
difference.

I'm writing this code to be read, and it's more readable with fewer extra
characters and duplicated type annotations. I'm not going to make it less
readable for a theoretical small efficiency improvement that could be done at a
lower level anyway.

+  final isDebugging = false;
+  final onDebugging = new StreamController<bool>().stream;
+
   /// A future that completes to the loaded suite once the suite's test has been
   /// run and completed successfully.
   ///
@@ -108,7 +113,7 @@ class LoadSuite extends RunnerSuite {
   }
 
   LoadSuite._(String name, void body(), this.suite, {TestPlatform platform})
-      : super(const VMEnvironment(), new Group.root([
+      : super(new Group.root([
         new LocalTest(name,
             new Metadata(timeout: new Timeout(new Duration(minutes: 5))),
             body)
@@ -116,7 +121,7 @@ class LoadSuite extends RunnerSuite {
 
   /// A constructor used by [changeSuite].
   LoadSuite._changeSuite(LoadSuite old, Future<RunnerSuite> this.suite)
-      : super(const VMEnvironment(), old.group, platform: old.platform);
+      : super(old.group, platform: old.platform);
 
   /// Creates a new [LoadSuite] that's identical to this one, but that
   /// transforms [suite] once it's loaded.
@@ -144,4 +149,6 @@ class LoadSuite extends RunnerSuite {
     await new Future.error(error.error, error.stackTrace);
     throw 'unreachable';
   }
+
+  Future close() async {}
 }