Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Unified Diff: src/compiler/typer.cc

Issue 1422893003: [turbofan] Always check that we make progress in the Typer. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/typer.cc
diff --git a/src/compiler/typer.cc b/src/compiler/typer.cc
index 2430d40e00a5df787f9f1a0b4f737144af17e2ea..0a2c308e3718c1c88236e5df2f3993daf9445a16 100644
--- a/src/compiler/typer.cc
+++ b/src/compiler/typer.cc
@@ -261,10 +261,10 @@ class Typer::Visitor : public Reducer {
current = Weaken(node, current, previous);
}
- DCHECK(previous->Is(current));
+ CHECK(previous->Is(current));
NodeProperties::SetType(node, current);
- if (!(previous->Is(current) && current->Is(previous))) {
+ if (!current->Is(previous)) {
// If something changed, revisit all uses.
return Changed(node);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698