Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 1422893003: [turbofan] Always check that we make progress in the Typer. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Always check that we make progress in the Typer. Turn the DCHECK in the Typer into a CHECK, and don't silently continue in production. This way we know that we will always make progress towards the fixpoint. R=jarin@chromium.org, rossberg@chromium.org Committed: https://crrev.com/16053273bfec561ee56226588ffe58912469f587 Cr-Commit-Position: refs/heads/master@{#31568}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/compiler/typer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-10-26 13:13:39 UTC) #1
Benedikt Meurer
Hey Jaro, Andreas, Kill all the defensive programming in TurboFan! Please take a look. Thanks, ...
5 years, 1 month ago (2015-10-26 13:14:26 UTC) #2
rossberg
LGTM, but does this actually hold? :)
5 years, 1 month ago (2015-10-26 13:15:54 UTC) #3
Benedikt Meurer
On 2015/10/26 13:15:54, rossberg wrote: > LGTM, but does this actually hold? :) Well, if ...
5 years, 1 month ago (2015-10-26 13:16:45 UTC) #4
Jarin
Yes! lgtm.
5 years, 1 month ago (2015-10-26 13:17:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422893003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422893003/1
5 years, 1 month ago (2015-10-26 13:17:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 14:07:21 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 14:07:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16053273bfec561ee56226588ffe58912469f587
Cr-Commit-Position: refs/heads/master@{#31568}

Powered by Google App Engine
This is Rietveld 408576698