Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1422873002: Reland 1: "mac: Add auto-close and share-read-only functionality to SharedMemory." (Closed)

Created:
5 years, 2 months ago by erikchen
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland 1: "mac: Add auto-close and share-read-only functionality to SharedMemory." The original CL had a bug in the unit tests where an incorrect parameter was passed to mach_vm_region. > base::FileDescriptor has a property |auto_close| that is used to indicate that > when the object is passed to an IPC message, the message takes ownership of the > underlying OS handle. Since SharedMemoryHandle needs to be interchangeable with > base::FileDescriptor, I added a property with similar functionality named > |ownership_passes_to_ipc_|. > > The method ShareToProcess() is used to lower the current and maximum protection > of the underlying OS handle before it is transferred to a different process. I > implemented this functionality for Mach memory objects. > > BUG=535711 > Committed: https://crrev.com/033bbbcb63cab781552dfb435c035131c423de30 > Cr-Commit-Position: refs/heads/master@{#355880} BUG=535711 TBR=tsepez@chromium.org, mark@chromium.org Committed: https://crrev.com/328bf3f3a685d97426e9095b7b3d58836ef665b0 Cr-Commit-Position: refs/heads/master@{#355941}

Patch Set 1 : Copy of patch set 5 from https://codereview.chromium.org/1418113003/. #

Patch Set 2 : Fix error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+443 lines, -22 lines) Patch
M base/memory/shared_memory_handle.h View 2 chunks +9 lines, -0 lines 0 comments Download
M base/memory/shared_memory_handle_mac.cc View 6 chunks +22 lines, -2 lines 0 comments Download
M base/memory/shared_memory_mac.cc View 3 chunks +69 lines, -1 line 0 comments Download
M base/memory/shared_memory_mac_unittest.cc View 1 7 chunks +164 lines, -14 lines 0 comments Download
M ipc/attachment_broker_mac_unittest.cc View 15 chunks +130 lines, -5 lines 0 comments Download
M ipc/attachment_broker_privileged_mac_unittest.cc View 4 chunks +13 lines, -0 lines 0 comments Download
M ipc/ipc_message_utils.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ipc/test_util_mac.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ipc/test_util_mac.cc View 1 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
erikchen
tbr-ing tsepez@ and mark@ since the error was trivial: In a unit test, I was ...
5 years, 2 months ago (2015-10-23 23:02:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422873002/20001
5 years, 2 months ago (2015-10-23 23:04:45 UTC) #4
Mark Mentovai
LGTM
5 years, 2 months ago (2015-10-23 23:09:11 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-24 00:47:02 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-24 00:49:33 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/328bf3f3a685d97426e9095b7b3d58836ef665b0
Cr-Commit-Position: refs/heads/master@{#355941}

Powered by Google App Engine
This is Rietveld 408576698