Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1422853009: Add mDNS discovery to the Fletch compiler (Closed)

Created:
5 years, 1 month ago by Søren Gjesse
Modified:
5 years, 1 month ago
Reviewers:
wibling
CC:
fletch+reviews_googlegroups.com, ahe, Karl Klose, lukechurch
Base URL:
git@github.com:dart-lang/fletch.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add mDNS discovery to the Fletch compiler This adds the new command 'x-discover' which will discover devices with the Fletch agent. This also adds the option to run discovery when asked for the IP address of a remote device. R=wibling@google.com BUG= Committed: https://github.com/dart-lang/fletch/commit/bc29f6b4db3d299dd8aee26ce8a7f288176feffd

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed review comments #

Patch Set 3 : Fixed warning in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -2 lines) Patch
M pkg/fletchc/.packages View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/fletchc/lib/src/driver/developer.dart View 4 chunks +35 lines, -2 lines 0 comments Download
M pkg/fletchc/lib/src/verbs/actions.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/fletchc/lib/src/verbs/documentation.dart View 1 chunk +5 lines, -0 lines 0 comments Download
A pkg/fletchc/lib/src/verbs/x_discover_verb.dart View 1 1 chunk +21 lines, -0 lines 0 comments Download
M pkg/mdns/lib/mdns.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Søren Gjesse
5 years, 1 month ago (2015-11-10 12:34:09 UTC) #1
Søren Gjesse
On 2015/11/10 12:34:09, Søren Gjesse wrote: For this to work on Mac OS the following ...
5 years, 1 month ago (2015-11-10 12:37:06 UTC) #2
wibling
lgtm https://codereview.chromium.org/1422853009/diff/1/pkg/fletchc/lib/src/driver/developer.dart File pkg/fletchc/lib/src/driver/developer.dart (right): https://codereview.chromium.org/1422853009/diff/1/pkg/fletchc/lib/src/driver/developer.dart#newcode360 pkg/fletchc/lib/src/driver/developer.dart:360: if (line.isEmpty) { NIT: Perhaps trim the line ...
5 years, 1 month ago (2015-11-10 12:46:35 UTC) #3
Søren Gjesse
https://codereview.chromium.org/1422853009/diff/1/pkg/fletchc/lib/src/driver/developer.dart File pkg/fletchc/lib/src/driver/developer.dart (right): https://codereview.chromium.org/1422853009/diff/1/pkg/fletchc/lib/src/driver/developer.dart#newcode360 pkg/fletchc/lib/src/driver/developer.dart:360: if (line.isEmpty) { On 2015/11/10 12:46:34, wibling wrote: > ...
5 years, 1 month ago (2015-11-10 15:55:11 UTC) #4
Søren Gjesse
5 years, 1 month ago (2015-11-10 15:56:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
bc29f6b4db3d299dd8aee26ce8a7f288176feffd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698