Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 1422853008: [heap] Make MarkInlinedFunctionsCode visitor private. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Make MarkInlinedFunctionsCode visitor private. Now that the VisitCode visitor is actually marking through to inlined code objects (as opposed to the VisitJSFunction visitor), we can make this helper method private again. R=ulan@chromium.org Committed: https://crrev.com/aca2176500df5ce5faf41c6720f58b74d38bb825 Cr-Commit-Position: refs/heads/master@{#31860}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M src/heap/mark-compact.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/heap/objects-visiting.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ulan
lgtm, nice!
5 years, 1 month ago (2015-11-06 14:38:15 UTC) #1
Michael Starzinger
5 years, 1 month ago (2015-11-06 14:38:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422853008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422853008/1
5 years, 1 month ago (2015-11-06 14:54:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 15:18:05 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 15:18:30 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aca2176500df5ce5faf41c6720f58b74d38bb825
Cr-Commit-Position: refs/heads/master@{#31860}

Powered by Google App Engine
This is Rietveld 408576698