Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart

Issue 1422853007: Fix missed merge conflict for merge request https://github.com/dart-lang/sdk/issues/24782 (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.js_emitter.program_builder; 5 library dart2js.js_emitter.program_builder;
6 6
7 import '../js_emitter.dart' show 7 import '../js_emitter.dart' show
8 ClassStubGenerator, 8 ClassStubGenerator,
9 CodeEmitterTask, 9 CodeEmitterTask,
10 computeMixinClass, 10 computeMixinClass,
(...skipping 405 matching lines...) Expand 10 before | Expand all | Expand 10 after
416 FunctionElement fn = member; 416 FunctionElement fn = member;
417 functionType = fn.type; 417 functionType = fn.type;
418 } else if (member.isGetter) { 418 } else if (member.isGetter) {
419 if (_compiler.trustTypeAnnotations) { 419 if (_compiler.trustTypeAnnotations) {
420 GetterElement getter = member; 420 GetterElement getter = member;
421 DartType returnType = getter.type.returnType; 421 DartType returnType = getter.type.returnType;
422 if (returnType.isFunctionType) { 422 if (returnType.isFunctionType) {
423 functionType = returnType; 423 functionType = returnType;
424 } else if (returnType.treatAsDynamic || 424 } else if (returnType.treatAsDynamic ||
425 _compiler.types.isSubtype(returnType, 425 _compiler.types.isSubtype(returnType,
426 backend.coreTypes.functionType)) { 426 backend.resolution.coreTypes.functionType)) {
427 if (returnType.isTypedef) { 427 if (returnType.isTypedef) {
428 TypedefType typedef = returnType; 428 TypedefType typedef = returnType;
429 // TODO(jacobr): can we just use typdef.unaliased instead? 429 // TODO(jacobr): can we just use typdef.unaliased instead?
430 functionType = typedef.element.functionSignature.type; 430 functionType = typedef.element.functionSignature.type;
431 } else { 431 } else {
432 // Other misc function type such as coreTypes.Function. 432 // Other misc function type such as coreTypes.Function.
433 // Allow any number of arguments. 433 // Allow any number of arguments.
434 isFunctionLike = true; 434 isFunctionLike = true;
435 } 435 }
436 } 436 }
(...skipping 574 matching lines...) Expand 10 before | Expand all | Expand 10 after
1011 Constant constant = new Constant(name, holder, constantValue); 1011 Constant constant = new Constant(name, holder, constantValue);
1012 _constants[constantValue] = constant; 1012 _constants[constantValue] = constant;
1013 } 1013 }
1014 } 1014 }
1015 1015
1016 Holder _registerStaticStateHolder() { 1016 Holder _registerStaticStateHolder() {
1017 return _registry.registerHolder( 1017 return _registry.registerHolder(
1018 namer.staticStateHolder, isStaticStateHolder: true); 1018 namer.staticStateHolder, isStaticStateHolder: true);
1019 } 1019 }
1020 } 1020 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698