Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 1422853003: [Autofill] Send the form name in Autofill uploads where metadata is collected. (Closed)

Created:
5 years, 1 month ago by Mathieu
Modified:
5 years, 1 month ago
Reviewers:
Evan Stade
CC:
chromium-reviews, rouslan+autofill_chromium.org, bondd+autofillwatch_chromium.org, jdonnelly+autofillwatch_chromium.org, browser-components-watch_chromium.org, estade+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Send the form name in Autofill uploads where metadata is collected. Controlled by the AutofillFieldMetadata trial, we send the form name as described in the bug. BUG=548366 Committed: https://crrev.com/6df39ba725668c2883322823734638248ab4257f Cr-Commit-Position: refs/heads/master@{#357046}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -1 line) Patch
M chrome/browser/autofill/autofill_server_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/form_structure.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M components/autofill/core/browser/form_structure_unittest.cc View 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mathieu
Hi, please have a look!
5 years, 1 month ago (2015-10-29 12:05:56 UTC) #2
Evan Stade
lgtm
5 years, 1 month ago (2015-10-30 00:12:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422853003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422853003/1
5 years, 1 month ago (2015-10-30 04:33:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 04:37:51 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 04:38:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6df39ba725668c2883322823734638248ab4257f
Cr-Commit-Position: refs/heads/master@{#357046}

Powered by Google App Engine
This is Rietveld 408576698