Add hint for use of ?. in conditions (issue 24649)

Add hint for use of ?. in conditions (issue 24649)

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/c687f29555f8099aeb9f436781b820852e3d58af

[Brian Wilkerson, 2015-10-25 17:29:04]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2015-10-25 17:48:52]

LGTM

https://codereview.chromium.org/1422813003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1422813003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:656: if (operator != null &&
operator.type == TokenType.QUESTION_PERIOD) {
if (operator?.type == TokenType.QUESTION_PERIOD) maybe? :-)

https://codereview.chromium.org/1422813003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:666: }
We could also validate every part of &&, ||, etc expression.

Do we need to validate AssertStatement and ConditionalStatement?

[Brian Wilkerson, 2015-10-25 22:11:40]

PTAL

https://codereview.chromium.org/1422813003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1422813003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:656: if (operator != null &&
operator.type == TokenType.QUESTION_PERIOD) {
I don't happen to find it to be very readable, but...

https://codereview.chromium.org/1422813003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:666: }
> We could also validate every part of &&, ||, etc expression.

Done

> Do we need to validate AssertStatement and ConditionalStatement?

Probably a good idea. Done

[scheglov, 2015-10-25 23:38:59]

You probably forgot to upload the new CL.

[Brian Wilkerson, 2015-10-25 23:48:54]

Sorry, yes. I told it to upload and forgot that I had to provide a title for the
patch set. It should be up now.

[scheglov, 2015-10-26 00:48:20]

LGTM

[pquitslund, 2015-10-28 04:40:35]

pquitslund@google.com changed reviewers:
+ pquitslund@google.com

[pquitslund, 2015-10-28 04:40:35]

Driving by...

https://codereview.chromium.org/1422813003/diff/20001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/error.dart (right):

https://codereview.chromium.org/1422813003/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/error.dart:3026: * Generate a hint for conditions
in control flow statements that uses the
uses => use?

[Brian Wilkerson, 2015-10-28 15:27:38]

https://codereview.chromium.org/1422813003/diff/20001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/error.dart (right):

https://codereview.chromium.org/1422813003/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/error.dart:3026: * Generate a hint for conditions
in control flow statements that uses the
Actually, it needed a bigger re-write than that. But thanks for catching it.

[Brian Wilkerson, 2015-10-28 15:28:47]

Committed patchset #2 (id:20001) manually as
c687f29555f8099aeb9f436781b820852e3d58af (presubmit successful).