Issue 1422793002: Use LIBRARY_SPECIFIC_UNITS instead of UNITS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1422793002: Use LIBRARY_SPECIFIC_UNITS instead of UNITS. (Closed)

Created:
5 years, 2 months ago by scheglov

Modified:
5 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Use LIBRARY_SPECIFIC_UNITS instead of UNITS. This reduces number of LibrarySpecificUnit instances from 10,000,000 to about 6,000. Also this slightly improves the code of corresponding 'buildInputs' methods. This saves some memory, but unfortunately does not win any performance. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f09778528afedc456112fdf1b032431f0d5f6e93

Total comments: 2

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+143 lines, -33 lines)			Patch
M	pkg/analyzer/lib/src/task/dart.dart	View	13 chunks	+54 lines, -27 lines	2 comments	Download
M	pkg/analyzer/lib/src/task/inputs.dart	View	3 chunks	+69 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/task/dart.dart	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/task/model.dart	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/src/task/dart_test.dart	View	5 chunks	+10 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Brian Wilkerson

I don't know whether it will have as much impact after we revert the one ...

5 years, 2 months ago (2015-10-23 13:58:57 UTC) #2

scheglov

5 years, 2 months ago (2015-10-23 15:32:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f09778528afedc456112fdf1b032431f0d5f6e93 (presubmit successful).