cc: Move surfaces hittesting test helpers out to a separate file

cc: Move surfaces hittesting test helpers out to a separate file

This will allow reuse by Mandoline.

BUG=533161
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/7a61510e805016a384055b1de043afdccd40543f
Cr-Commit-Position: refs/heads/master@{#355889}

[Fady Samuel, 2015-10-22 22:51:01]

fsamuel@chromium.org changed reviewers:
+ jbauman@chromium.org

[jbauman, 2015-10-22 22:56:09]

Actually, could you try moving the test helpers into cc/test? danakj@ mentioned
that that might be a better place to put them.

[Fady Samuel, 2015-10-23 14:19:55]

fsamuel@chromium.org changed reviewers:
+ danakj@chromium.org

[Fady Samuel, 2015-10-23 14:19:55]

+danakj@ for OWNERs and since you suggested moving to cc/test.

The intent is to reuse some of these test helpers in Mandoline tests.

[danakj, 2015-10-23 18:35:02]

LGTM % jbauman

https://codereview.chromium.org/1422783002/diff/20001/cc/test/surface_hittest...
File cc/test/surface_hittest_test_helpers.cc (right):

https://codereview.chromium.org/1422783002/diff/20001/cc/test/surface_hittest...
cc/test/surface_hittest_test_helpers.cc:78: return root_frame.Pass();
nit: return makes an rvalue, you don't need to Pass()

https://codereview.chromium.org/1422783002/diff/20001/cc/test/surface_hittest...
cc/test/surface_hittest_test_helpers.cc:91: return root_frame.Pass();
nit: return makes an rvalue, you don't need to Pass()

[Fady Samuel, 2015-10-23 19:22:28]

CQ'ing

https://codereview.chromium.org/1422783002/diff/20001/cc/test/surface_hittest...
File cc/test/surface_hittest_test_helpers.cc (right):

https://codereview.chromium.org/1422783002/diff/20001/cc/test/surface_hittest...
cc/test/surface_hittest_test_helpers.cc:78: return root_frame.Pass();
On 2015/10/23 18:35:02, danakj wrote:
> nit: return makes an rvalue, you don't need to Pass()

Done.

https://codereview.chromium.org/1422783002/diff/20001/cc/test/surface_hittest...
cc/test/surface_hittest_test_helpers.cc:91: return root_frame.Pass();
On 2015/10/23 18:35:02, danakj wrote:
> nit: return makes an rvalue, you don't need to Pass()

Done.

[Fady Samuel, 2015-10-23 19:22:30]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2015-10-23 19:22:31]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1422783002/#ps40001
(title: "Addressed Dana's comments")

[commit-bot: I haz the power, 2015-10-23 19:23:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422783002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422783002/40001

[commit-bot: I haz the power, 2015-10-23 19:26:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-23 19:26:33]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Fady Samuel, 2015-10-23 20:44:15]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2015-10-23 20:44:16]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1422783002/#ps60001
(title: "Fix GN DEPS I hope")

[commit-bot: I haz the power, 2015-10-23 20:44:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422783002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422783002/60001

[commit-bot: I haz the power, 2015-10-23 21:25:24]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-23 21:26:24]

Patchset 4 (id:??) landed as
https://crrev.com/7a61510e805016a384055b1de043afdccd40543f
Cr-Commit-Position: refs/heads/master@{#355889}