chrome/app/close_handle_hook_win.cc - Issue 1422773008: Fixing remaining VC++ 2015 64-bit build breaks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/close_handle_hook_win.cc

Issue 1422773008: Fixing remaining VC++ 2015 64-bit build breaks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removing unnecessary #if defined(s) Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/app/close_handle_hook_win.cc

diff --git a/chrome/app/close_handle_hook_win.cc b/chrome/app/close_handle_hook_win.cc

index efec307a62a511e6dc57838bddceab0918224d8c..0c109074cdea18c9fb89e8a8f4e80b8ac764f557 100644

--- a/chrome/app/close_handle_hook_win.cc

+++ b/chrome/app/close_handle_hook_win.cc

@@ -142,8 +142,8 @@ void EATPatch(HMODULE module, const char* function_name,

// Perform the patch.

#pragma warning(push)

-#pragma warning(disable: 4311)

- // These casts generate warnings because they are 32 bit specific.

+#pragma warning(disable : 4311 4302)

+ // These casts generate truncation warnings because they are 32 bit specific.

*eat_entry = reinterpret_cast<DWORD>(new_function) -

reinterpret_cast<DWORD>(module);

#pragma warning(pop)