Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: build/common.gypi

Issue 1422773008: Fixing remaining VC++ 2015 64-bit build breaks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing unnecessary #if defined(s) Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index ca65fc31caa20734aa0cac0868a30544aa2dc8a7..b905253a20dbad1f38a0d4f985286b10a6955251 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3142,6 +3142,7 @@
'_SCL_SECURE_NO_DEPRECATE',
],
'msvs_disabled_warnings': [
+ # forcing value to bool 'true' or 'false' (performance warning)
4800,
],
'msvs_settings': {
@@ -5622,7 +5623,7 @@
# it's enabled. This will generally only be true for system-level
# installed Express users.
'msvs_disabled_warnings': [
- 4702,
+ 4702, # unreachable code
],
}],
],
@@ -5706,6 +5707,10 @@
# should work through these at some point -- they may be removed from
# the RTM release in the /W4 set.
4456, 4457, 4458, 4459,
+
+ # TODO(brucedawson): http://crbug.com/554200 4312 is a VS
+ # 2015 64-bit warning for integer to larger pointer
+ 4312,
],
'msvs_settings': {
'VCCLCompilerTool': {

Powered by Google App Engine
This is Rietveld 408576698