Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: third_party/libxml/libxml.gyp

Issue 1422773008: Fixing remaining VC++ 2015 64-bit build breaks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Supply reference for handles-are-32-bits claim Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libxml/libxml.gyp
diff --git a/third_party/libxml/libxml.gyp b/third_party/libxml/libxml.gyp
index 493ed044db387596ec9f3d6fca7717f7af8f0e91..500ab415226d5f29c7a4b51a4eed3eca7a95dd7a 100644
--- a/third_party/libxml/libxml.gyp
+++ b/third_party/libxml/libxml.gyp
@@ -260,11 +260,11 @@
['OS=="mac" or OS=="android"', {'defines': ['_REENTRANT']}],
['OS=="win"', {
'product_name': 'libxml2',
- # Disable unimportant 'unused variable' warning, and
- # signed/unsigned comparison warning. The signed/unsigned (4101)
- # is fixed upstream and can be removed eventually.
+ # Disable unimportant 'unused variable' warning.
# TODO(jschuh): http://crbug.com/167187 size_t -> int
- 'msvs_disabled_warnings': [ 4018, 4101, 4267 ],
+ # TODO(brucedawson): http://crbug.com/554200 4311 is a VS
+ # 2015 64-bit warning for pointer truncation
Nico 2015/11/16 21:31:07 Is the TODO to fix this warning? Not clear what th
brucedawson 2015/11/17 00:24:39 The TODO is to fix the code so that the warning su
+ 'msvs_disabled_warnings': [ 4018, 4267, 4311, ],
}, { # else: OS!="win"
'product_name': 'xml2',
}],

Powered by Google App Engine
This is Rietveld 408576698