third_party/WebKit/Source/wtf/BitVector.cpp - Issue 1422773008: Fixing remaining VC++ 2015 64-bit build breaks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/BitVector.cpp

Issue 1422773008: Fixing remaining VC++ 2015 64-bit build breaks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Supply reference for handles-are-32-bits claim Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/BitVector.cpp

diff --git a/third_party/WebKit/Source/wtf/BitVector.cpp b/third_party/WebKit/Source/wtf/BitVector.cpp

index 79a3322886878cb2029371adb32147a72973adc1..edac5b906f2b8bfdcfb485b885e176595ad4f216 100644

--- a/third_party/WebKit/Source/wtf/BitVector.cpp

+++ b/third_party/WebKit/Source/wtf/BitVector.cpp

@@ -78,7 +78,7 @@ BitVector::OutOfLineBits* BitVector::OutOfLineBits::create(size_t numBits)

// Because of the way BitVector stores the pointer, memory tools

// will erroneously report a leak here.

WTF_ANNOTATE_SCOPED_MEMORY_LEAK;

- numBits = (numBits + bitsInPointer() - 1) & ~(bitsInPointer() - 1);

+ numBits = (numBits + bitsInPointer() - 1) & ~(bitsInPointer() - static_cast<size_t>(1));

size_t size = sizeof(OutOfLineBits) + sizeof(uintptr_t) * (numBits / bitsInPointer());

void* allocation = Partitions::bufferMalloc(size);

OutOfLineBits* result = new (NotNull, allocation) OutOfLineBits(numBits);