content/shell/browser/shell_web_contents_view_delegate_win.cc - Issue 1422773008: Fixing remaining VC++ 2015 64-bit build breaks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_web_contents_view_delegate_win.cc

Issue 1422773008: Fixing remaining VC++ 2015 64-bit build breaks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sync to latest Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/browser/shell_web_contents_view_delegate_win.cc

diff --git a/content/shell/browser/shell_web_contents_view_delegate_win.cc b/content/shell/browser/shell_web_contents_view_delegate_win.cc

index d5a16baab85dae51d19e446a6d87a70fa5b98bd0..c5bffd595cb953678038d5bd3ac9bef7cfd02072 100644

--- a/content/shell/browser/shell_web_contents_view_delegate_win.cc

+++ b/content/shell/browser/shell_web_contents_view_delegate_win.cc

@@ -82,7 +82,7 @@ void ShellWebContentsViewDelegate::ShowContextMenu(

HMENU menu = CreateMenu();

HMENU sub_menu = CreatePopupMenu();

- AppendMenu(menu, MF_STRING | MF_POPUP, (UINT)sub_menu, L"");

+ AppendMenu(menu, MF_STRING | MF_POPUP, (UINT_PTR)sub_menu, L"");

Will Harris 2015/11/10 18:05:14 nit: do not use C-style cast here.

brucedawson 2015/11/10 18:43:26 I thought I could get grandfathered in :-)

int index = 0;

if (params_.media_type == WebContextMenuData::MediaTypeNone &&