Fixing remaining VC++ 2015 64-bit build breaks

base/win/win_util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // =============================================================================
 // PLEASE READ
 //
 // In general, you should not be adding stuff to this file.

[danakj, 2015/11/14 00:34:59]

This reads a lot like the base/OWNERS comment. This new function seems to be
needed in a lot of places (chrome, content, components, sandbox) and so this
seems like a good place for it. I also think it's a very good idea to use
helpers instead of casts for something like this.

I think you should probably + a base/win/ owner specifically for this though, to
be fair.

 //
 // - If your thing is only used in one place, just put it in a reasonable
 //   location in or near that one place. It's nice you want people to be able
 //   to re-use your function, but realistically, if it hasn't been necessary
 //   before after so many years of development, it's probably not going to be
 //   used in other places in the future unless you know of them now.
 //
 // - If your thing is used by multiple callers and is UI-related, it should
 //   probably be in app/win/ instead. Try to put it in the most specific file
 //   possible (avoiding the *_util files when practical).
@@ skipping 30 matching lines @@
     int     iMenuWidth;
     int     iMenuHeight;
     LOGFONTW lfMenuFont;
     LOGFONTW lfStatusFont;
     LOGFONTW lfMessageFont;
 };
 
 namespace base {
 namespace win {
 
+inline uint32_t HandleToUint32(HANDLE h) {
+  // Cast through uintptr_t and then unsigned int to make the truncation to
+  // 32 bits explicit. Handles are size of-pointer but are always 32-bit values.

[danakj, 2015/11/14 00:34:59]

Can you point to some documentation verifying this assumption?

+  return static_cast<uint32_t>(reinterpret_cast<uintptr_t>(h));
+}
+
 BASE_EXPORT void GetNonClientMetrics(NONCLIENTMETRICS_XP* metrics);
 
 // Returns the string representing the current user sid.
 BASE_EXPORT bool GetUserSidString(std::wstring* user_sid);
 
 // Returns false if user account control (UAC) has been disabled with the
 // EnableLUA registry flag. Returns true if user account control is enabled.
 // NOTE: The EnableLUA registry flag, which is ignored on Windows XP
 // machines, might still exist and be set to 0 (UAC disabled), in which case
 // this function will return false. You should therefore check this flag only
@@ skipping 87 matching lines @@
 // CreateWindow and CreateDC. Windows 8 and above allow the kernel component
 // of these calls to be disabled which can cause undefined behaviour such as
 // crashes. This function can be used to guard areas of code using these calls
 // and provide a fallback path if necessary.
 BASE_EXPORT bool IsUser32AndGdi32Available();
 
 }  // namespace win
 }  // namespace base
 
 #endif  // BASE_WIN_WIN_UTIL_H_