Fixing remaining VC++ 2015 64-bit build breaks

components/startup_metric_utils/browser/startup_metric_utils.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/startup_metric_utils/browser/startup_metric_utils.h"
 
 #include "base/containers/hash_tables.h"
 #include "base/environment.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
@@ skipping 118 matching lines @@
     return false;
   }
 
   // Look for the struct housing information for the current process.
   DWORD proc_id = ::GetCurrentProcessId();
   size_t index = 0;
   while (index < buffer.size()) {
     DCHECK_LE(index + sizeof(SYSTEM_PROCESS_INFORMATION_EX), buffer.size());
     SYSTEM_PROCESS_INFORMATION_EX* proc_info =
         reinterpret_cast<SYSTEM_PROCESS_INFORMATION_EX*>(buffer.data() + index);
-    if (reinterpret_cast<DWORD>(proc_info->UniqueProcessId) == proc_id) {
+    if (reinterpret_cast<uintptr_t>(proc_info->UniqueProcessId) == proc_id) {

[Will Harris, 2015/11/10 18:05:14]

UniqueProcessId is a HANDLE, shouldn't this be a double cast similar to others,
or is there an implicit cast from uintptr_t -> DWORD happening? No warnings for
that?

[brucedawson, 2015/11/10 18:43:26]

There's no truncation because proc_id is extended to uintptr_t size to do the
comparison. But that means this code is wrong if the sign bit is set, so I
should add another cast. It probably only affects the INVALID_HANDLE value case,
but still.

Yet another reason to have a truncation function or macro.

       *hard_fault_count = proc_info->HardFaultCount;
       return true;
     }
     // The list ends when NextEntryOffset is zero. This also prevents busy
     // looping if the data is in fact invalid.
     if (proc_info->NextEntryOffset <= 0)
       return false;
     index += proc_info->NextEntryOffset;
   }
 
@@ skipping 349 matching lines @@
 
 base::Time MainEntryPointTime() {
   return g_main_entry_point_time.Get();
 }
 
 StartupTemperature GetStartupTemperature() {
   return g_startup_temperature;
 }
 
 }  // namespace startup_metric_utils