Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/profiler/heap-snapshot-generator.cc

Issue 1422773007: Make JSFunction::BodyDescriptor the only single place that knows how to iterate JSFunction's body. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressing comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects-inl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/profiler/heap-snapshot-generator.h" 5 #include "src/profiler/heap-snapshot-generator.h"
6 6
7 #include "src/code-stubs.h" 7 #include "src/code-stubs.h"
8 #include "src/conversions.h" 8 #include "src/conversions.h"
9 #include "src/debug/debug.h" 9 #include "src/debug/debug.h"
10 #include "src/profiler/allocation-tracker.h" 10 #include "src/profiler/allocation-tracker.h"
(...skipping 1140 matching lines...) Expand 10 before | Expand all | Expand 10 after
1151 SetInternalReference(js_fun, entry, 1151 SetInternalReference(js_fun, entry,
1152 "shared", shared_info, 1152 "shared", shared_info,
1153 JSFunction::kSharedFunctionInfoOffset); 1153 JSFunction::kSharedFunctionInfoOffset);
1154 TagObject(js_fun->context(), "(context)"); 1154 TagObject(js_fun->context(), "(context)");
1155 SetInternalReference(js_fun, entry, 1155 SetInternalReference(js_fun, entry,
1156 "context", js_fun->context(), 1156 "context", js_fun->context(),
1157 JSFunction::kContextOffset); 1157 JSFunction::kContextOffset);
1158 SetWeakReference(js_fun, entry, 1158 SetWeakReference(js_fun, entry,
1159 "next_function_link", js_fun->next_function_link(), 1159 "next_function_link", js_fun->next_function_link(),
1160 JSFunction::kNextFunctionLinkOffset); 1160 JSFunction::kNextFunctionLinkOffset);
1161 STATIC_ASSERT(JSFunction::kNextFunctionLinkOffset 1161 // Ensure no new weak references appeared in JSFunction.
1162 == JSFunction::kNonWeakFieldsEndOffset); 1162 STATIC_ASSERT(JSFunction::kCodeEntryOffset ==
1163 JSFunction::kNonWeakFieldsEndOffset);
1164 STATIC_ASSERT(JSFunction::kCodeEntryOffset + kPointerSize ==
1165 JSFunction::kNextFunctionLinkOffset);
1163 STATIC_ASSERT(JSFunction::kNextFunctionLinkOffset + kPointerSize 1166 STATIC_ASSERT(JSFunction::kNextFunctionLinkOffset + kPointerSize
1164 == JSFunction::kSize); 1167 == JSFunction::kSize);
1165 } else if (obj->IsJSGlobalObject()) { 1168 } else if (obj->IsJSGlobalObject()) {
1166 JSGlobalObject* global_obj = JSGlobalObject::cast(obj); 1169 JSGlobalObject* global_obj = JSGlobalObject::cast(obj);
1167 SetInternalReference(global_obj, entry, "native_context", 1170 SetInternalReference(global_obj, entry, "native_context",
1168 global_obj->native_context(), 1171 global_obj->native_context(),
1169 JSGlobalObject::kNativeContextOffset); 1172 JSGlobalObject::kNativeContextOffset);
1170 SetInternalReference(global_obj, entry, "global_proxy", 1173 SetInternalReference(global_obj, entry, "global_proxy",
1171 global_obj->global_proxy(), 1174 global_obj->global_proxy(),
1172 JSGlobalObject::kGlobalProxyOffset); 1175 JSGlobalObject::kGlobalProxyOffset);
(...skipping 1994 matching lines...) Expand 10 before | Expand all | Expand 10 after
3167 for (int i = 1; i < sorted_strings.length(); ++i) { 3170 for (int i = 1; i < sorted_strings.length(); ++i) {
3168 writer_->AddCharacter(','); 3171 writer_->AddCharacter(',');
3169 SerializeString(sorted_strings[i]); 3172 SerializeString(sorted_strings[i]);
3170 if (writer_->aborted()) return; 3173 if (writer_->aborted()) return;
3171 } 3174 }
3172 } 3175 }
3173 3176
3174 3177
3175 } // namespace internal 3178 } // namespace internal
3176 } // namespace v8 3179 } // namespace v8
OLDNEW
« no previous file with comments | « src/objects-inl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698