Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1422763004: Missing resources crash SampleFilterQuality. (Closed)

Created:
5 years, 1 month ago by bungeman-skia
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Missing resources crash SampleFilterQuality. The FilterQuality slide segfaults if resources cannot be loaded. This is particularly noticeable with an Android build, as by default resources are not available. Committed: https://skia.googlesource.com/skia/+/fbd87d611a16d6e1397226d1c8418c810c76b598

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M samplecode/SampleFilterQuality.cpp View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
bungeman-skia
This is an update for https://codereview.chromium.org/1410243009 .
5 years, 1 month ago (2015-11-10 21:10:27 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422763004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422763004/1
5 years, 1 month ago (2015-11-10 21:10:39 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-10 21:22:11 UTC) #7
bsalomon
lgtm
5 years, 1 month ago (2015-11-10 21:23:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422763004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422763004/1
5 years, 1 month ago (2015-11-10 21:29:09 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 21:29:46 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fbd87d611a16d6e1397226d1c8418c810c76b598

Powered by Google App Engine
This is Rietveld 408576698