Issue 1422753005: Minimize enter/exit isolate calls during startup and shutdown of service isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1422753005: Minimize enter/exit isolate calls during startup and shutdown of service isolate. (Closed)

Created:
5 years, 1 month ago by siva

Modified:
5 years, 1 month ago

Reviewers:
zra, Cutch

CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Minimize enter/exit isolate calls during startup and shutdown of service isolate. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/47da86799d27740a5e54d12a4ddda9aba006c3b9

Patch Set 1 #

Total comments: 1

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -12 lines)			Patch
	M	runtime/vm/service_isolate.cc	View		5 chunks	+8 lines, -12 lines	1 comment	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

siva

Committed patchset #1 (id:1) manually as 47da86799d27740a5e54d12a4ddda9aba006c3b9 (presubmit successful).

5 years, 1 month ago (2015-10-29 16:57:30 UTC) #4

zra

5 years, 1 month ago (2015-10-30 04:47:50 UTC) #6

Message was sent while issue was closed.

dbc

https://codereview.chromium.org/1422753005/diff/1/runtime/vm/service_isolate.cc
File runtime/vm/service_isolate.cc (right):

https://codereview.chromium.org/1422753005/diff/1/runtime/vm/service_isolate....
runtime/vm/service_isolate.cc:355: HandleScope handle_scope(T);
Calling Dart::ShutdownIsolate() inside of a HandleScope causes the current
thread's zone to be NULL, which will cause the assert at handles.cc:112 to fail
when we leave the handle scope. Probably that was the initial reason for
splitting up the scopes.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages