[Smart Lock, prefs reconciliation] IOS factory

[Smart Lock, prefs reconciliation] IOS factory

BUG=517087
Committed: https://crrev.com/9332f2bf7c1852f6c1dd7491bf8c33fa053c0cd5
Cr-Commit-Position: refs/heads/master@{#359402}

[melandory, 2015-11-11 13:30:58]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-11 13:31:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422713011/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422713011/60001

[commit-bot: I haz the power, 2015-11-11 13:37:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-11 13:37:53]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[melandory, 2015-11-11 16:01:27]

melandory@chromium.org changed reviewers:
+ vabr@chromium.org

[melandory, 2015-11-11 16:01:28]

Hi Vaclav,

PTAL. Thanks!

[melandory, 2015-11-11 16:01:30]

Hi Vaclav,

PTAL. Thanks!

[vabr (Chromium), 2015-11-11 16:11:33]

LGTM with comments.
Thanks, Tanja!
Vaclav

https://codereview.chromium.org/1422713011/diff/80001/ios/chrome/browser/pass...
File
ios/chrome/browser/passwords/ios_chrome_password_manager_setting_migrator_service_factory.cc
(right):

https://codereview.chromium.org/1422713011/diff/80001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/ios_chrome_password_manager_setting_migrator_service_factory.cc:11:
#include "ios/public/provider/chrome/browser/keyed_service_provider.h"
Are you using this?

https://codereview.chromium.org/1422713011/diff/80001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/ios_chrome_password_manager_setting_migrator_service_factory.cc:32:
BrowserStateDependencyManager::GetInstance()) {}
Should you #include
"components/keyed_service/ios/browser_state_dependency_manager.h" for this?

https://codereview.chromium.org/1422713011/diff/80001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/ios_chrome_password_manager_setting_migrator_service_factory.cc:42:
scoped_ptr<password_manager::PasswordManagerSettingMigratorService>
You can shorten the last 5 lines to:

return make_scoped_ptr(
           new password_manager::PasswordManagerSettingMigratorService(
               browser_state->GetSyncablePrefs()));

https://codereview.chromium.org/1422713011/diff/80001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/ios_chrome_password_manager_setting_migrator_service_factory.cc:52:
return GetBrowserStateRedirectedInIncognito(context);
Please #include "ios/chrome/browser/browser_state/browser_state_otr_helper.h"
for this.

[melandory, 2015-11-12 15:35:58]

melandory@chromium.org changed reviewers:
+ droger@chromium.org

[melandory, 2015-11-12 15:35:58]

droger@chromium.org: Please review changes in 

ios/

[droger, 2015-11-12 15:44:12]

ios/ LGTM
thanks!

FYI: it seems that vabr is owner of ios/chrome/browser/password

[melandory, 2015-11-12 15:45:42]

https://codereview.chromium.org/1422713011/diff/80001/ios/chrome/browser/pass...
File
ios/chrome/browser/passwords/ios_chrome_password_manager_setting_migrator_service_factory.cc
(right):

https://codereview.chromium.org/1422713011/diff/80001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/ios_chrome_password_manager_setting_migrator_service_factory.cc:11:
#include "ios/public/provider/chrome/browser/keyed_service_provider.h"
On 2015/11/11 16:11:33, vabr (Chromium) wrote:
> Are you using this?

Nope :(

https://codereview.chromium.org/1422713011/diff/80001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/ios_chrome_password_manager_setting_migrator_service_factory.cc:32:
BrowserStateDependencyManager::GetInstance()) {}
On 2015/11/11 16:11:33, vabr (Chromium) wrote:
> Should you #include
> "components/keyed_service/ios/browser_state_dependency_manager.h" for this?

Done.

https://codereview.chromium.org/1422713011/diff/80001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/ios_chrome_password_manager_setting_migrator_service_factory.cc:42:
scoped_ptr<password_manager::PasswordManagerSettingMigratorService>
On 2015/11/11 16:11:33, vabr (Chromium) wrote:
> You can shorten the last 5 lines to:
> 
> return make_scoped_ptr(
>            new password_manager::PasswordManagerSettingMigratorService(
>                browser_state->GetSyncablePrefs()));

Done.

https://codereview.chromium.org/1422713011/diff/80001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/ios_chrome_password_manager_setting_migrator_service_factory.cc:52:
return GetBrowserStateRedirectedInIncognito(context);
On 2015/11/11 16:11:33, vabr (Chromium) wrote:
> Please #include "ios/chrome/browser/browser_state/browser_state_otr_helper.h"
> for this.

Done.

[melandory, 2015-11-12 15:46:24]

The CQ bit was checked by melandory@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-12 15:46:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422713011/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422713011/100001

[commit-bot: I haz the power, 2015-11-12 16:27:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-12 16:27:35]

Dry run: This issue passed the CQ dry run.

[melandory, 2015-11-12 21:48:30]

The CQ bit was checked by melandory@chromium.org

[melandory, 2015-11-12 21:48:30]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/1422713011/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-11-12 21:49:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1422713011/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1422713011/100001

[commit-bot: I haz the power, 2015-11-12 21:54:54]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-11-12 21:56:23]

Patchset 6 (id:??) landed as
https://crrev.com/9332f2bf7c1852f6c1dd7491bf8c33fa053c0cd5
Cr-Commit-Position: refs/heads/master@{#359402}