Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 1422713007: XFA: Remove dead code in CBC_BufferedImageLuminanceSource and friends. (Closed)

Created:
5 years, 1 month ago by Lei Zhang
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

XFA: Remove dead code in CBC_BufferedImageLuminanceSource and friends. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/961c04a7c30746a395347133d0507811b0dece05

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -39 lines) Patch
M xfa/src/fxbarcode/BC_BinaryBitmap.h View 1 chunk +0 lines, -2 lines 0 comments Download
M xfa/src/fxbarcode/BC_BinaryBitmap.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.h View 1 chunk +2 lines, -9 lines 0 comments Download
M xfa/src/fxbarcode/BC_BufferedImageLuminanceSource.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M xfa/src/fxbarcode/BC_LuminanceSource.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
This code looks silly.
5 years, 1 month ago (2015-10-30 20:23:18 UTC) #2
Tom Sepez
LGTM.
5 years, 1 month ago (2015-10-30 20:27:05 UTC) #3
Lei Zhang
5 years, 1 month ago (2015-10-30 20:43:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
961c04a7c30746a395347133d0507811b0dece05 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698