Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 1422703009: Revert[4] of "stop using drawSprite (at least w/ no filters) as it is going away" (Closed)

Created:
5 years, 1 month ago by reed1
Modified:
5 years, 1 month ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert[4] of "stop using drawSprite (at least w/ no filters) as it is going away" This reverts commit 67b8b5e67a427382fed8c5d8b3c70a21ed2492c6. BUG=skia: TBR= Previous revert was due to faulty unittest (now fixed) -- unrelated to this CL. Committed: https://skia.googlesource.com/skia/+/6f45c1714786a54adec156f2416a14aa142adf05

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M samplecode/SampleAll.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M src/effects/SkColorFilterImageFilter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/SkMergeImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrRecordReplaceDraw.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M src/images/SkImageDecoder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422703009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422703009/1
5 years, 1 month ago (2015-11-04 16:22:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422703009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422703009/1
5 years, 1 month ago (2015-11-04 16:25:28 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 16:34:10 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6f45c1714786a54adec156f2416a14aa142adf05

Powered by Google App Engine
This is Rietveld 408576698