Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Unified Diff: third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxSettingsTab.js

Issue 1422703003: [DevTools] Use ListWidget for rendering of EditFileSystemView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxSettingsTab.js
diff --git a/third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxSettingsTab.js b/third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxSettingsTab.js
index f905b901a53497af1af291ef9313fc0282a3c138..f994054fe81dd1aed05f2dcb0a760ee9d3738ffa 100644
--- a/third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxSettingsTab.js
+++ b/third_party/WebKit/Source/devtools/front_end/settings/FrameworkBlackboxSettingsTab.js
@@ -56,18 +56,21 @@ WebInspector.FrameworkBlackboxSettingsTab.prototype = {
_addButtonClicked: function()
{
- this._list.addNewItem(this._setting.getAsArray().length);
+ this._list.addNewItem(this._setting.getAsArray().length, {pattern: "", disabled: false});
},
/**
* @override
* @param {*} item
+ * @param {boolean} editable
* @return {!Element}
*/
- renderItem: function(item)
+ renderItem: function(item, editable)
{
var element = createElementWithClass("div", "blackbox-list-item");
- element.createChild("div", "blackbox-pattern").textContent = item.pattern;
+ var pattern = element.createChild("div", "blackbox-pattern");
+ pattern.textContent = item.pattern;
+ pattern.title = item.pattern;
element.createChild("div", "blackbox-separator");
element.createChild("div", "blackbox-behavior").textContent = item.disabled ? this._disabledLabel : this._blackboxLabel;
if (item.disabled)
@@ -77,9 +80,10 @@ WebInspector.FrameworkBlackboxSettingsTab.prototype = {
/**
* @override
+ * @param {*} item
* @param {number} index
*/
- removeItemRequested: function(index)
+ removeItemRequested: function(item, index)
{
var patterns = this._setting.getAsArray();
patterns.splice(index, 1);
@@ -91,39 +95,31 @@ WebInspector.FrameworkBlackboxSettingsTab.prototype = {
/**
* @override
- * @param {*|null} item
+ * @param {*} item
* @param {!WebInspector.ListWidget.Editor} editor
+ * @param {boolean} isNew
*/
- commitEdit: function(item, editor)
+ commitEdit: function(item, editor, isNew)
{
- var pattern = item;
- if (!pattern)
- pattern = {pattern: "", disabled: false};
-
- pattern.pattern = editor.control("pattern").value.trim();
- pattern.disabled = editor.control("behavior").value === this._disabledLabel;
+ item.pattern = editor.control("pattern").value.trim();
+ item.disabled = editor.control("behavior").value === this._disabledLabel;
var list = this._setting.getAsArray();
- if (!item)
- list.push(pattern);
+ if (isNew)
+ list.push(item);
this._setting.setAsArray(list);
},
/**
* @override
- * @param {*|null} item
+ * @param {*} item
* @return {!WebInspector.ListWidget.Editor}
*/
beginEdit: function(item)
{
var editor = this._createEditor();
- if (item) {
- editor.control("pattern").value = item.pattern;
- editor.control("behavior").value = item.disabled ? this._disabledLabel : this._blackboxLabel;
- } else {
- editor.control("pattern").value = "";
- editor.control("behavior").value = this._blackboxLabel;
- }
+ editor.control("pattern").value = item.pattern;
+ editor.control("behavior").value = item.disabled ? this._disabledLabel : this._blackboxLabel;
return editor;
},

Powered by Google App Engine
This is Rietveld 408576698