Issue 1422633002: Merge to XFA: Change DEPS hooks paths to include 'pdfium/'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1422633002: Merge to XFA: Change DEPS hooks paths to include 'pdfium/'. (Closed)

Created:
5 years, 2 months ago by Oliver Chang

Modified:
5 years, 2 months ago

Reviewers:
Lei Zhang, Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

More Reviews

Description

Merge to XFA: Change DEPS hooks paths to include 'pdfium/'. This will break existing checkouts based on the instructions provided. Instead of having a single pdfium directory, checkouts will now compromise of: ("repo" can be named anything) repo/.gclient repo/pdfium/.git repo/pdfium/others... To convert an existing checkout, do something like: mkdir repo mv pdfium repo rm repo/pdfium/.gclient_entries # will be regenerated, with a warning mv repo/pdfium/.gclient repo edit repo/.gclient and change "name: '.'" to "name: 'pdfium'" Instructions for getting a new checkout are in README.md in this CL. R=thestig@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/1406383003 . Committed: https://pdfium.googlesource.com/pdfium/+/5a21e14fb699453fe9d0c7bd0de12c434b102938

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -7 lines)			Patch
	M	DEPS	View		4 chunks	+4 lines, -4 lines	0 comments	Download
	M	docs/build.md	View		1 chunk	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Oliver Chang

5 years, 2 months ago (2015-10-21 22:19:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5a21e14fb699453fe9d0c7bd0de12c434b102938 (presubmit successful).

Expand Messages | Collapse Messages